test: make subr mocks variadic for native-comp, add arity meta-test

Re-enabling native-comp surfaced a suite-wide fragility. When a test redefines a C primitive (or a native-compiled function), native-comp routes native callers through a trampoline that calls the mock with the primitive's maximum arity. A fixed-arity mock narrower than the primitive then throws wrong-number-of-arguments, intermittently, as the eln-cache fills.

I swept every arity-narrow subr mock to append &rest _ (188 sites, preserving any named args the body uses), and added tests/test-meta-subr-mock-arity.el, which fails make test on any subr mock too narrow for the primitive's arity. The rule isn't "never mock a subr". The suite mocks message and completing-read freely. It's "a subr mock must accept the primitive's arity."

Background, the three failure modes, and the research are in docs/native-comp-subr-mocking.org.

1 files changed, 4 insertions, 4 deletions

diff --git a/tests/test-prog-go-commands.el b/tests/test-prog-go-commands.el
index a2fc0625..6e699834 100644
--- a/tests/test-prog-go-commands.el
+++ b/tests/test-prog-go-commands.el
@@ -54,7 +54,7 @@
                 ((symbol-function 'lsp-deferred)
                  (lambda (&rest _) (setq started t)))
                 ((symbol-function 'executable-find)
-                 (lambda (path) (when (equal path gopls-path) "/usr/bin/gopls"))))
+                 (lambda (path &rest _) (when (equal path gopls-path) "/usr/bin/gopls"))))
         (cj/go-setup))
       (should started))))
 
@@ -66,7 +66,7 @@
                 ((symbol-function 'electric-pair-local-mode) #'ignore)
                 ((symbol-function 'lsp-deferred)
                  (lambda (&rest _) (setq started t)))
-                ((symbol-function 'executable-find) (lambda (_) nil)))
+                ((symbol-function 'executable-find) (lambda (_ &rest _) nil)))
         (cj/go-setup))
       (should-not started))))
 
@@ -104,7 +104,7 @@
   "Normal: with delve on PATH, `gud-gdb' is called with `dlv debug'."
   (let (started)
     (cl-letf (((symbol-function 'executable-find)
-               (lambda (path) (when (equal path dlv-path) "/usr/bin/dlv")))
+               (lambda (path &rest _) (when (equal path dlv-path) "/usr/bin/dlv")))
               ((symbol-function 'file-executable-p) (lambda (_) nil))
               ((symbol-function 'gud-gdb)
                (lambda (cmd &rest _) (setq started cmd))))
@@ -117,7 +117,7 @@
   "Error: delve missing -> message + no gud-gdb call."
   (let ((started nil)
         (msg nil))
-    (cl-letf (((symbol-function 'executable-find) (lambda (_) nil))
+    (cl-letf (((symbol-function 'executable-find) (lambda (_ &rest _) nil))
               ((symbol-function 'file-executable-p) (lambda (_) nil))
               ((symbol-function 'gud-gdb)
                (lambda (&rest _) (setq started t)))