aboutsummaryrefslogtreecommitdiff
path: root/tests/test-prog-shell--tool-warnings.el
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-07-18 17:45:00 -0500
committerCraig Jennings <c@cjennings.net>2026-07-18 17:45:00 -0500
commit3f734920d2713924124b3fe8b0edf0c4b9c82bc8 (patch)
treef4f65074418bddf71717fdbea9cd6069669fa888 /tests/test-prog-shell--tool-warnings.el
parent347e36c6fd4b52e14731594e6f745f6efdccadb1 (diff)
downloaddotemacs-3f734920d2713924124b3fe8b0edf0c4b9c82bc8.tar.gz
dotemacs-3f734920d2713924124b3fe8b0edf0c4b9c82bc8.zip
fix(prog): cover classic modes and warn for missing dev tools
Classic go-mode and js-mode buffers got none of the ts-mode setup, and web-mode got the format key without the promised company/flyspell/LSP. All three now run the shared setup. The web-mode LSP attach guards on the HTML language server, so machines without it stay silent instead of prompting. gopls, clangd, clang-format, bash-language-server, shfmt, and shellcheck now warn at load when missing. The shfmt, shellcheck, and clang-format blocks gate on :if, which evaluates once at startup, so an absent tool silently disabled that setup until the next restart. I also put ~/go/bin on exec-path at load so the gopls check doesn't misreport a gopls installed there.
Diffstat (limited to 'tests/test-prog-shell--tool-warnings.el')
-rw-r--r--tests/test-prog-shell--tool-warnings.el34
1 files changed, 34 insertions, 0 deletions
diff --git a/tests/test-prog-shell--tool-warnings.el b/tests/test-prog-shell--tool-warnings.el
new file mode 100644
index 00000000..37c1e559
--- /dev/null
+++ b/tests/test-prog-shell--tool-warnings.el
@@ -0,0 +1,34 @@
+;;; test-prog-shell--tool-warnings.el --- Load-time missing-tool warnings -*- lexical-binding: t; -*-
+
+;;; Commentary:
+;; The config audit flagged bash-language-server, shfmt, and shellcheck
+;; for the load-time missing-tool warnings pyright/prettier already
+;; have. The shfmt and flycheck use-package blocks gate on `:if
+;; (executable-find ...)', which evaluates once at startup — an absent
+;; tool silently disables that setup until the next restart, so the
+;; warn is the only visible trace.
+
+;;; Code:
+
+(require 'ert)
+(require 'cl-lib)
+
+(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(add-to-list 'load-path (expand-file-name "tests" user-emacs-directory))
+(require 'testutil-format-wiring)
+(format-test--ensure-packages-init)
+(require 'prog-shell)
+
+(ert-deftest test-prog-shell-warns-when-tools-missing ()
+ "Error: loading without the shell tools on PATH warns for each one."
+ (let ((warned '()))
+ (cl-letf (((symbol-function 'executable-find) (lambda (&rest _) nil))
+ ((symbol-function 'display-warning)
+ (lambda (_type msg &rest _) (push msg warned))))
+ (load (expand-file-name "modules/prog-shell.el" user-emacs-directory) nil t))
+ (dolist (tool '("bash-language-server" "shfmt" "shellcheck"))
+ (should (cl-some (lambda (m) (string-match-p (regexp-quote tool) m))
+ warned)))))
+
+(provide 'test-prog-shell--tool-warnings)
+;;; test-prog-shell--tool-warnings.el ends here