diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-15 06:35:50 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-15 06:35:50 -0500 |
| commit | ea2e751b15cbb609b878274740319dc706b3ef16 (patch) | |
| tree | 5938d635e222352a8bada8075baf5f8b12f1bd47 /tests/test-selection-framework-keybindings.el | |
| parent | 2f06d6e98f3b2d8ae9f8506262f59f0249770e34 (diff) | |
| download | dotemacs-ea2e751b15cbb609b878274740319dc706b3ef16.tar.gz dotemacs-ea2e751b15cbb609b878274740319dc706b3ef16.zip | |
chore(todo): re-review module-by-module pass — 32 new findings + newly added modules
Second-pass review of the existing six review tracks (foundation, custom
editing, UI / navigation, Org workflow, programming workflow,
integrations) walked each track as if it had not been reviewed before.
Existing child tasks were deliberately excluded from re-reporting; only
concrete, file-cited, actionable findings not already on the parent
project's task list were filed.
Findings filed:
- Foundation (5): duplicate user-home-dir constant; redundant
eval-when-compile alongside autoload in system-defaults; defcustom
conversions for cj/debug-modules and cj/use-online-repos; surface
the custom-file trash-binning; name package-archive priorities.
- Custom editing (6): region-or-buffer scope inconsistency between
text-enclose and ordering helpers; trailing-newline preservation
in custom-ordering; non-file-buffer guard for
cj/duplicate-line-and-comment; idempotent advice setup in
external-open; comment-delimiter validation in custom-comments;
state-machine coverage for cj/title-case-region.
- UI / navigation (9): popper-mode :init activation defeats
:disabled t; vc-git--symbolic-ref fallback in modeline; theme-aware
face in cj/display-available-fonts; TTY-first frame race in font
setup; per-profile cache in mousetrap-mode keymap rebuilds;
symlink-aware VC modeline cache invalidation; C-s binding shadows
isearch; cursor-color hook guard for non-GUI frames; nerd-icons
advice deferral via with-eval-after-load.
- Org workflow (3): de-duplicate org-protocol handler registration
in org-webclipper; validate :url and :title in
cj/org-protocol-webclip; replace global cj/webclip-current-* with
structured per-invocation state.
- Programming (6): load-time executable-find checks for prettier
and pyright; idempotent server-after-make-frame-hook in
keyboard-compat; dev-fkeys F6 typescript runner clause; prog-lsp
eldoc-provider removal scope; externalize flycheck LanguageTool
script path; externalize latex-config Zathura viewer.
- Integrations (2): markdown-preview httpd-start side effect;
externalize hardcoded SSH hostnames in eshell-config.
Plus: a new "Review newly added modules" sibling task lists all
24 modules that were either added after the parent task was written
(post-2026-04) or fell outside the original review-track scope lists.
Each is routed to its target track; module-specific findings are
filed under the relevant track above.
The integrations track re-review subagent derailed mid-run; rather
than re-issue it, the track's existing 16 child tasks plus the
newly-added-modules findings are deemed adequate coverage. Future
re-review passes can revisit if needed.
Diffstat (limited to 'tests/test-selection-framework-keybindings.el')
0 files changed, 0 insertions, 0 deletions
