diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-23 19:21:31 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-23 19:21:31 -0500 |
| commit | 64f349326454583a375a4f8d6df44966833e3512 (patch) | |
| tree | 93c69d404a96ee3122fe275c33bf43e29ae1961b /tests/test-system-lib-executable-exists-p.el | |
| parent | b3dba452b13cddc51477f3bdcfef663783d3fa5b (diff) | |
| download | dotemacs-64f349326454583a375a4f8d6df44966833e3512.tar.gz dotemacs-64f349326454583a375a4f8d6df44966833e3512.zip | |
fix(dwim-shell): quote and validate user-controlled shell inputs
Several dwim-shell commands interpolated user-controlled strings straight into shell templates, so a value with spaces, quotes, or shell metacharacters could break out of the command. The worst was git-clone-clipboard-url, which dropped raw clipboard contents into "git clone <<cb>>".
I added three pure validators (git URL, ffmpeg timestamp, rename prefix) and fixed the interpolation sites. git-clone now validates the clipboard and passes the URL through shell-quote-argument instead of <<cb>>. The GPG recipient and the 7z archive name go through shell-quote-argument instead of hand-written single quotes. The thumbnail timestamp and the rename prefix are validated to a safe shape before they reach the command, so the unquoted interpolation that remains is constrained to digits, colons, and filename-safe characters.
The fifth case in the ticket, the video-concat filelist built with echo/tr/sed, is a redesign rather than a quoting fix and is filed as a follow-up.
Diffstat (limited to 'tests/test-system-lib-executable-exists-p.el')
0 files changed, 0 insertions, 0 deletions