test: make subr mocks variadic for native-comp, add arity meta-test

Re-enabling native-comp surfaced a suite-wide fragility. When a test redefines a C primitive (or a native-compiled function), native-comp routes native callers through a trampoline that calls the mock with the primitive's maximum arity. A fixed-arity mock narrower than the primitive then throws wrong-number-of-arguments, intermittently, as the eln-cache fills.

I swept every arity-narrow subr mock to append &rest _ (188 sites, preserving any named args the body uses), and added tests/test-meta-subr-mock-arity.el, which fails make test on any subr mock too narrow for the primitive's arity. The rule isn't "never mock a subr". The suite mocks message and completing-read freely. It's "a subr mock must accept the primitive's arity."

Background, the three failure modes, and the research are in docs/native-comp-subr-mocking.org.

1 files changed, 4 insertions, 4 deletions

diff --git a/tests/test-video-audio-recording--build-video-command.el b/tests/test-video-audio-recording--build-video-command.el
index 3b79c9ecb..4f2909784 100644
--- a/tests/test-video-audio-recording--build-video-command.el
+++ b/tests/test-video-audio-recording--build-video-command.el
@@ -21,7 +21,7 @@
   "Wayland command pipes wf-recorder to ffmpeg."
   (let ((cj/recording-mic-boost 2.0)
         (cj/recording-system-volume 1.0))
-    (cl-letf (((symbol-function 'executable-find) (lambda (_prog) t)))
+    (cl-letf (((symbol-function 'executable-find) (lambda (_prog &rest _) t)))
       (let ((cmd (cj/recording--build-video-command "mic" "sys" "/tmp/out.mkv" t)))
         (should (string-match-p "wf-recorder.*|.*ffmpeg" cmd))
         (should (string-match-p "-i pipe:0" cmd))
@@ -60,7 +60,7 @@
   "Device names with special characters are shell-quoted in Wayland mode."
   (let ((cj/recording-mic-boost 1.0)
         (cj/recording-system-volume 1.0))
-    (cl-letf (((symbol-function 'executable-find) (lambda (_prog) t)))
+    (cl-letf (((symbol-function 'executable-find) (lambda (_prog &rest _) t)))
       (let ((cmd (cj/recording--build-video-command
                   "device with spaces" "sys" "/tmp/out.mkv" t)))
         ;; shell-quote-argument escapes spaces with backslashes
@@ -70,7 +70,7 @@
   "Output filename with spaces is shell-quoted in Wayland mode."
   (let ((cj/recording-mic-boost 1.0)
         (cj/recording-system-volume 1.0))
-    (cl-letf (((symbol-function 'executable-find) (lambda (_prog) t)))
+    (cl-letf (((symbol-function 'executable-find) (lambda (_prog &rest _) t)))
       (let ((cmd (cj/recording--build-video-command
                   "mic" "sys" "/tmp/my recording.mkv" t)))
         ;; Filename should be quoted/escaped
@@ -103,7 +103,7 @@
 
 (ert-deftest test-video-audio-recording--build-video-command-error-wayland-no-wf-recorder ()
   "Wayland mode signals error when wf-recorder is not installed."
-  (cl-letf (((symbol-function 'executable-find) (lambda (_prog) nil)))
+  (cl-letf (((symbol-function 'executable-find) (lambda (_prog &rest _) nil)))
     (should-error (cj/recording--build-video-command "mic" "sys" "/tmp/out.mkv" t)
                   :type 'user-error)))