diff options
| author | Craig Jennings <c@cjennings.net> | 2026-11-20 15:59:47 -0600 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-11-20 15:59:47 -0600 |
| commit | 4df81e5e751cf50c45e1b82e694394ddcb133ada (patch) | |
| tree | 269e7d0dc65bf71965adc73c55858b2b7ae2f068 /tests | |
| parent | 1e679c7193f55950849cf9b9d9ac41108db26b3f (diff) | |
| download | dotemacs-4df81e5e751cf50c45e1b82e694394ddcb133ada.tar.gz dotemacs-4df81e5e751cf50c45e1b82e694394ddcb133ada.zip | |
refactor(telega): retire the Telegram client to the archive
I stopped using Telegram in Emacs, so the client goes to the archive.
- The module and its tests moved to archive/.
- The setup script and docker build files moved with them.
- I dropped the init.el require and the make telega-image target.
- The dashboard loses its Telegram launcher. Rows are now 5 4 2 2.
- C-; T is free again.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-dashboard-config-launchers.el | 31 | ||||
| -rw-r--r-- | tests/test-init-module-headers.el | 1 | ||||
| -rw-r--r-- | tests/test-setup-telega.bats | 134 | ||||
| -rw-r--r-- | tests/test-telega-config--docker-pin.el | 212 | ||||
| -rw-r--r-- | tests/test-telega-config--server-death.el | 131 | ||||
| -rw-r--r-- | tests/test-telega-config.el | 58 |
6 files changed, 15 insertions, 552 deletions
diff --git a/tests/test-dashboard-config-launchers.el b/tests/test-dashboard-config-launchers.el index 76fbcc42..566c693a 100644 --- a/tests/test-dashboard-config-launchers.el +++ b/tests/test-dashboard-config-launchers.el @@ -25,24 +25,23 @@ (require 'dashboard-config) -;; Telegram moved from "g" to "G" so "g" is free for dashboard refresh. -;; Signal ("S") added as the 14th launcher. -;; Weather ("w") added after Agenda as the 15th launcher (top-row daily glance). -(defconst test-dash--keys '("c" "d" "t" "a" "w" "r" "b" "f" "m" "e" "i" "G" "s" "l")) +;; "g" is dashboard refresh (the dired/magit convention), so no launcher takes it. +;; Signal ("S") and Telegram ("G") left the table when their clients were +;; retired to archive/. Weather ("w") sits after Agenda as a top-row daily glance. +(defconst test-dash--keys '("c" "d" "t" "a" "w" "r" "b" "f" "m" "e" "i" "s" "l")) ;; ----------------------------- launcher table -------------------------------- (ert-deftest test-dashboard-launchers-keys-in-order () - "Normal: 14 launchers with the expected keys in display order. -(Signal left the table when the signel client was retired to archive/.)" - (should (= 14 (length cj/dashboard--launchers))) + "Normal: 13 launchers with the expected keys in display order." + (should (= 13 (length cj/dashboard--launchers))) (should (equal test-dash--keys (mapcar (lambda (l) (nth 0 l)) cj/dashboard--launchers)))) (ert-deftest test-dashboard-launchers-labels-in-order () - "Normal: labels in display order (Telegram and Slack reordered so Slack sits -next to Linear on the last navigator row)." + "Normal: labels in display order, with Slack next to Linear on the last +navigator row." (should (equal '("Code" "Files" "Terminal" "Agenda" "Weather" "Feeds" "Books" - "Flashcards" "Music" "Email" "IRC" "Telegram" "Slack" "Linear") + "Flashcards" "Music" "Email" "IRC" "Slack" "Linear") (mapcar (lambda (l) (nth 3 l)) cj/dashboard--launchers)))) (ert-deftest test-dashboard-row-sizes-cover-all-launchers () @@ -52,8 +51,8 @@ next to Linear on the last navigator row)." ;; --------------------------- navigator rows ---------------------------------- -(ert-deftest test-dashboard-navigator-rows-grouped-5-4-3-2 () - "Normal: navigator derives rows per `cj/dashboard--row-sizes' (5 4 3 2), with +(ert-deftest test-dashboard-navigator-rows-grouped-5-4-2-2 () + "Normal: navigator derives rows per `cj/dashboard--row-sizes' (5 4 2 2), with Weather joining the top row and Slack and Linear pairing on the last row." (cl-letf (((symbol-function 'nerd-icons-faicon) (lambda (n &rest _) (concat "I:" n))) ((symbol-function 'nerd-icons-devicon) (lambda (n &rest _) (concat "I:" n))) @@ -63,7 +62,9 @@ Weather joining the top row and Slack and Linear pairing on the last row." ((symbol-function 'nerd-icons-wicon) (lambda (n &rest _) (concat "I:" n)))) (let ((rows (cj/dashboard--navigator-rows))) (should (= 4 (length rows))) - (should (equal '(5 4 3 2) (mapcar #'length rows))) + (should (equal '(5 4 2 2) (mapcar #'length rows))) + (should (equal '("Email" "IRC") + (mapcar (lambda (b) (nth 1 b)) (nth 2 rows)))) (should (equal '("Code" "Files" "Terminal" "Agenda" "Weather") (mapcar (lambda (b) (nth 1 b)) (nth 0 rows)))) (should (equal '("Slack" "Linear") @@ -99,7 +100,6 @@ Weather joining the top row and Slack and Linear pairing on the last row." ((symbol-function 'mu4e) (lambda (&rest _) (push 'email calls))) ((symbol-function 'cj/erc-switch-to-buffer-with-completion) (lambda (&rest _) (push 'irc calls))) ((symbol-function 'cj/slack-start) (lambda (&rest _) (push 'slack calls))) - ((symbol-function 'cj/telega) (lambda (&rest _) (push 'tg calls))) ((symbol-function 'pearl-list-issues) (lambda (&rest _) (push 'linear calls))) ;; wttrin is invoked via `call-interactively', so the stub must be ;; a command -- a plain variadic lambda masked the real arity bug. @@ -108,12 +108,11 @@ Weather joining the top row and Slack and Linear pairing on the last row." (dolist (key test-dash--keys) (call-interactively (keymap-lookup map key))) (should (memq 'code calls)) - (should (memq 'tg calls)) (should (memq 'linear calls)) (should (memq 'm-toggle calls)) (should (memq 'm-load calls)) (should (memq 'weather calls)) - (should (= 15 (length calls)))))) ; 14 keys, Music fires two + (should (= 14 (length calls)))))) ; 13 keys, Music fires two (provide 'test-dashboard-config-launchers) ;;; test-dashboard-config-launchers.el ends here diff --git a/tests/test-init-module-headers.el b/tests/test-init-module-headers.el index f89d6624..d8a31f3b 100644 --- a/tests/test-init-module-headers.el +++ b/tests/test-init-module-headers.el @@ -135,7 +135,6 @@ "restclient-config" "slack-config" "system-commands" - "telega-config" "tramp-config" "transcription-config" "video-audio-recording" diff --git a/tests/test-setup-telega.bats b/tests/test-setup-telega.bats deleted file mode 100644 index 518ecc7b..00000000 --- a/tests/test-setup-telega.bats +++ /dev/null @@ -1,134 +0,0 @@ -#!/usr/bin/env bats -# Tests for the helpers in scripts/setup-telega.sh. -# -# Sources the script (so only the helpers come in -- `main' runs only -# when the script is executed directly) and stubs `docker' / `command' -# in each test so nothing actually talks to the docker daemon or -# requires a real telega-server image. - -setup() { - source "${BATS_TEST_DIRNAME}/../scripts/setup-telega.sh" -} - -# --------------------------- ensure_docker_installed ---------------------- - -@test "ensure_docker_installed: succeeds when docker is on PATH" { - command() { - if [[ "$1" == "-v" && "$2" == "docker" ]]; then - echo "/usr/bin/docker" - return 0 - fi - builtin command "$@" - } - run ensure_docker_installed - [ "$status" -eq 0 ] - [[ "$output" == *"docker present"* ]] -} - -@test "ensure_docker_installed: fails when docker is missing" { - command() { - if [[ "$1" == "-v" && "$2" == "docker" ]]; then - return 1 - fi - builtin command "$@" - } - run ensure_docker_installed - [ "$status" -eq 1 ] - [[ "$output" == *"docker not found"* ]] - [[ "$output" == *"get-docker"* ]] -} - -# --------------------------- ensure_docker_running ------------------------ - -@test "ensure_docker_running: succeeds when 'docker info' exits 0" { - docker() { return 0; } - run ensure_docker_running - [ "$status" -eq 0 ] - [[ "$output" == *"reachable"* ]] -} - -@test "ensure_docker_running: fails when 'docker info' errors" { - docker() { return 1; } - run ensure_docker_running - [ "$status" -eq 1 ] - [[ "$output" == *"cannot talk"* ]] - [[ "$output" == *"docker group"* || "$output" == *"systemctl"* ]] -} - -# --------------------------- pull_or_announce_image ----------------------- - -@test "pull_or_announce_image: points at make telega-image when no image is set" { - TELEGA_DOCKER_IMAGE="" - run pull_or_announce_image - [ "$status" -eq 0 ] - [[ "$output" == *"make telega-image"* ]] -} - -@test "pull_or_announce_image: pulls when TELEGA_DOCKER_IMAGE is set" { - TELEGA_DOCKER_IMAGE="example/telega:1" - docker() { - if [[ "$1" == "pull" ]]; then - echo "pulling $2" - return 0 - fi - return 1 - } - run pull_or_announce_image - [ "$status" -eq 0 ] - [[ "$output" == *"pulled example/telega:1"* ]] -} - -@test "pull_or_announce_image: fails when 'docker pull' errors" { - TELEGA_DOCKER_IMAGE="example/telega:1" - docker() { return 1; } - run pull_or_announce_image - [ "$status" -eq 1 ] - [[ "$output" == *"pull failed"* ]] -} - -# --------------------------- ensure_telega_package ------------------------ - -@test "ensure_telega_package: fails when emacs is missing" { - command() { - if [[ "$1" == "-v" && "$2" == "emacs" ]]; then - return 1 - fi - builtin command "$@" - } - run ensure_telega_package - [ "$status" -eq 1 ] - [[ "$output" == *"emacs not on PATH"* ]] -} - -@test "ensure_telega_package: skips when telega already installed" { - # Stub emacs so the first --batch probe (package-installed-p) exits 0. - emacs() { return 0; } - export -f emacs - run ensure_telega_package - [ "$status" -eq 0 ] - [[ "$output" == *"already installed"* ]] -} - -@test "ensure_telega_package: installs when telega not yet present" { - # First call (probe) returns 1 "not installed"; second call (install) returns 0. - emacs() { - if [[ "$*" == *"package-installed-p"* ]]; then - return 1 - fi - return 0 - } - export -f emacs - run ensure_telega_package - [ "$status" -eq 0 ] - [[ "$output" == *"telega installed"* ]] -} - -@test "ensure_telega_package: reports failure when install fails" { - # Both calls return non-zero so the install path errors. - emacs() { return 1; } - export -f emacs - run ensure_telega_package - [ "$status" -eq 1 ] - [[ "$output" == *"install failed"* ]] - [[ "$output" == *"M-x package-install"* ]] -} diff --git a/tests/test-telega-config--docker-pin.el b/tests/test-telega-config--docker-pin.el deleted file mode 100644 index 8f5b62bd..00000000 --- a/tests/test-telega-config--docker-pin.el +++ /dev/null @@ -1,212 +0,0 @@ -;;; test-telega-config--docker-pin.el --- Tests for the telega docker image pin -*- lexical-binding: t; -*- - -;;; Commentary: -;; Tests for pinning the telega-server container image. -;; -;; telega infers its image from `telega-tdlib-min-version' and only pins to a -;; version tag when min and max versions are equal and the version ends in -;; ".0". This config has min "1.8.66" and max nil, so the inference always -;; falls through to "zevlg/telega-server:latest" -- a moving tag that can -;; swap the server out from under a fixed elisp version without notice. -;; -;; Since 2026-08-25 the pin names an image built locally from -;; docker/telega-server/Dockerfile (upstream's image is missing a shared -;; library, zevlg/telega.el#596). Three files have to agree on that image: -;; the defcustom default, the Makefile's build tag, and the Dockerfile's -;; digest-pinned base. The tests below hold them together. - -;;; Code: - -(require 'ert) -(require 'cl-lib) - -(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory)) -(require 'telega-config) - -(defun test-telega-config--file-string (relative) - "Return the contents of RELATIVE under `user-emacs-directory'." - (with-temp-buffer - (insert-file-contents (expand-file-name relative user-emacs-directory)) - (buffer-string))) - -(defun test-telega-config--pin-default () - "Return the defcustom's shipped default, not the live value. -Customizing the pin (including to nil) is not a test failure; only -changing the shipped default is." - (eval (car (get 'cj/telega-docker-image 'standard-value)) t)) - -;; -- cj/--telega-docker-pinned-image ----------------------------------------- - -(ert-deftest test-telega-config-pin-returns-configured-reference () - "Normal: a configured pin is returned verbatim." - (let ((cj/telega-docker-image "zevlg/telega-server@sha256:abc123")) - (should (equal (cj/--telega-docker-pinned-image) - "zevlg/telega-server@sha256:abc123")))) - -(ert-deftest test-telega-config-pin-nil-when-unset () - "Boundary: no pin returns nil so telega's own inference stays in charge." - (let ((cj/telega-docker-image nil)) - (should-not (cj/--telega-docker-pinned-image)))) - -(ert-deftest test-telega-config-pin-nil-for-empty-string () - "Boundary: an empty or whitespace pin is not a reference. -An empty string would otherwise reach the docker command line as a blank -image argument, which fails in a way that looks unrelated to this setting." - (let ((cj/telega-docker-image "")) - (should-not (cj/--telega-docker-pinned-image))) - (let ((cj/telega-docker-image " ")) - (should-not (cj/--telega-docker-pinned-image)))) - -(ert-deftest test-telega-config-pin-nil-for-non-string () - "Error: a non-string pin is ignored rather than passed to the shell." - (let ((cj/telega-docker-image 'latest)) - (should-not (cj/--telega-docker-pinned-image))) - (let ((cj/telega-docker-image 42)) - (should-not (cj/--telega-docker-pinned-image)))) - -(ert-deftest test-telega-config-pin-trims-surrounding-whitespace () - "Boundary: a pin with stray whitespace is trimmed, not rejected. -A trailing newline is easy to introduce when pasting a digest from docker." - (let ((cj/telega-docker-image " zevlg/telega-server@sha256:abc123\n")) - (should (equal (cj/--telega-docker-pinned-image) - "zevlg/telega-server@sha256:abc123")))) - -;; -- cj/--telega-docker-image-name (the advice) ------------------------------ - -(ert-deftest test-telega-config-image-advice-prefers-the-pin () - "Normal: with a pin set, the advice returns it instead of calling telega." - (let ((cj/telega-docker-image "zevlg/telega-server@sha256:abc123") - (called nil)) - (should (equal (cj/--telega-docker-image-name - (lambda () (setq called t) "zevlg/telega-server:latest")) - "zevlg/telega-server@sha256:abc123")) - (should-not called))) - -(ert-deftest test-telega-config-image-advice-delegates-without-a-pin () - "Boundary: with no pin, telega's own inference is used unchanged. -Removing the pin must restore stock behavior rather than break the image -name, so this stays a reversible setting." - (let ((cj/telega-docker-image nil)) - (should (equal (cj/--telega-docker-image-name - (lambda () "zevlg/telega-server:latest")) - "zevlg/telega-server:latest")))) - -(ert-deftest test-telega-config-image-advice-is-named-and-removable () - "Normal: the advice is a named function so it can be removed by reference." - (should (fboundp 'cj/--telega-docker-image-name))) - -;; -- the shipped default and the files it depends on ------------------------- - -(ert-deftest test-telega-config-pin-default-matches-makefile-build-tag () - "Normal: the default pin is exactly the tag `make telega-image' builds. -The image is built locally, so the pin is a tag rather than a registry -digest. The Makefile owns the tag; the defcustom must name the same one -or a fresh machine builds an image telega never looks for." - (let ((makefile (test-telega-config--file-string "Makefile"))) - (should (string-match "^TELEGA_IMAGE[ \t]*[?:]?=[ \t]*\\([^ \t\n]+\\)" makefile)) - (should (equal (test-telega-config--pin-default) - (match-string 1 makefile))))) - -(ert-deftest test-telega-config-pin-default-is-a-local-tag-not-a-digest () - "Boundary: the default is a plain tag, with no registry digest suffix. -A locally built image has no RepoDigest, so a digest reference here could -never resolve." - (let ((default (test-telega-config--pin-default))) - (should (stringp default)) - (should (string-match-p "\\`[a-z0-9./-]+:[A-Za-z0-9._-]+\\'" default)) - (should-not (string-match-p "@sha256:" default)))) - -(ert-deftest test-telega-config-dockerfile-pins-base-image-by-digest () - "Normal: the Dockerfile's base is an immutable upstream digest. -This is where the digest guarantee the old pin gave now lives. A tag in -the FROM line would let upstream swap the base under a rebuild." - (let ((dockerfile (test-telega-config--file-string "docker/telega-server/Dockerfile"))) - (should (string-match-p - "^FROM zevlg/telega-server@sha256:[0-9a-f]\\{64\\}[ \t]*$" - dockerfile)))) - -(ert-deftest test-telega-config-dockerfile-adds-the-missing-library () - "Normal: the Dockerfile installs libglycin, the whole reason it exists. -Upstream's image fails to start without it (zevlg/telega.el#596)." - (let ((dockerfile (test-telega-config--file-string "docker/telega-server/Dockerfile"))) - (should (string-match-p "^RUN apk add .*libglycin" dockerfile)))) - -;; -- cj/--telega-docker-image-present-p (the docker boundary) ---------------- -;; Exercised against a fake `docker' executable on a private exec-path rather -;; than by mocking `call-process' (a subr; see the native-comp mocking gotcha). - -(defun test-telega-config--with-fake-docker (exit-code thunk) - "Call THUNK with a fake `docker' on `exec-path' that exits EXIT-CODE." - (let* ((dir (make-temp-file "fake-docker-" t)) - (script (expand-file-name "docker" dir))) - (unwind-protect - (progn - (with-temp-file script - (insert (format "#!/bin/sh\nexit %d\n" exit-code))) - (set-file-modes script #o700) - (let ((exec-path (list dir))) - (funcall thunk))) - (delete-directory dir t)))) - -(ert-deftest test-telega-config-image-present-p-true-when-inspect-succeeds () - "Normal: `docker image inspect' exiting 0 means the image is present." - (test-telega-config--with-fake-docker 0 - (lambda () (should (cj/--telega-docker-image-present-p "cj/telega-server:x"))))) - -(ert-deftest test-telega-config-image-present-p-nil-when-inspect-fails () - "Boundary: a non-zero exit (no such image) reads as not present." - (test-telega-config--with-fake-docker 1 - (lambda () (should-not (cj/--telega-docker-image-present-p "cj/telega-server:x"))))) - -(ert-deftest test-telega-config-image-present-p-nil-without-docker () - "Error: with no docker on `exec-path', the helper returns nil instead of -signalling, so the launcher can still route the user to the make target." - (let ((exec-path nil)) - (should-not (cj/--telega-docker-image-present-p "cj/telega-server:x")))) - -;; -- cj/telega refuses to launch against a missing local image --------------- - -(ert-deftest test-telega-config-missing-image-message-names-image-and-target () - "Normal: the message names the missing image and the make target that builds it." - (let ((msg (cj/--telega-missing-image-message "cj/telega-server:x"))) - (should (string-match-p "cj/telega-server:x" msg)) - (should (string-match-p "make telega-image" msg)))) - -(ert-deftest test-telega-config-launcher-errors-when-pinned-image-is-absent () - "Error: with a pin set and no such image, `cj/telega' stops with the make hint. -Without this, docker fails to pull a local-only tag and the error names a -registry the image was never meant to come from." - (let ((cj/telega-docker-image "cj/telega-server:x") - (launched nil)) - (cl-letf (((symbol-function 'locate-library) (lambda (&rest _) "telega.el")) - ((symbol-function 'cj/--telega-docker-image-present-p) (lambda (_) nil)) - ((symbol-function 'telega) (lambda (&rest _) (setq launched t)))) - (let ((err (should-error (cj/telega) :type 'user-error))) - (should (string-match-p "make telega-image" (cadr err)))) - (should-not launched)))) - -(ert-deftest test-telega-config-launcher-runs-when-pinned-image-is-present () - "Normal: with the pinned image present, `cj/telega' launches telega." - (let ((cj/telega-docker-image "cj/telega-server:x") - (launched nil)) - (cl-letf (((symbol-function 'locate-library) (lambda (&rest _) "telega.el")) - ((symbol-function 'cj/--telega-docker-image-present-p) (lambda (_) t)) - ((symbol-function 'telega) (lambda (&rest _) (setq launched t)))) - (cj/telega) - (should launched)))) - -(ert-deftest test-telega-config-launcher-skips-image-check-without-a-pin () - "Boundary: with no pin, telega infers and pulls its own image; no check runs." - (let ((cj/telega-docker-image nil) - (checked nil) - (launched nil)) - (cl-letf (((symbol-function 'locate-library) (lambda (&rest _) "telega.el")) - ((symbol-function 'cj/--telega-docker-image-present-p) - (lambda (_) (setq checked t) nil)) - ((symbol-function 'telega) (lambda (&rest _) (setq launched t)))) - (cj/telega) - (should-not checked) - (should launched)))) - -(provide 'test-telega-config--docker-pin) -;;; test-telega-config--docker-pin.el ends here diff --git a/tests/test-telega-config--server-death.el b/tests/test-telega-config--server-death.el deleted file mode 100644 index 1151fa7e..00000000 --- a/tests/test-telega-config--server-death.el +++ /dev/null @@ -1,131 +0,0 @@ -;;; test-telega-config--server-death.el --- Tests for the telega-server death alert -*- lexical-binding: t; -*- - -;;; Commentary: -;; Tests for the telega-server death sentinel. telega's own sentinel only -;; calls `message' on an abnormal exit, which scrolls away unseen -- so a -;; dead server reads as a quiet Telegram. These pin the alert that replaces -;; that silence. - -;;; Code: - -(require 'ert) -(require 'cl-lib) - -(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory)) -(require 'telega-config) - -;; -- cj/--telega-server-death-p ---------------------------------------------- - -(ert-deftest test-telega-config-death-p-nonzero-status-is-death () - "Normal: a non-zero exit status is an abnormal death." - (should (cj/--telega-server-death-p 1)) - (should (cj/--telega-server-death-p 139))) - -(ert-deftest test-telega-config-death-p-segv-signal-is-death () - "Normal: a signal number (SIGSEGV is 11) counts as death. -This is the observed failure -- the server segfaults rather than exiting." - (should (cj/--telega-server-death-p 11))) - -(ert-deftest test-telega-config-death-p-zero-is-clean-exit () - "Boundary: exit status 0 is a clean shutdown and must not alert. -Quitting telega deliberately would otherwise page on every exit." - (should-not (cj/--telega-server-death-p 0))) - -(ert-deftest test-telega-config-death-p-nil-is-not-death () - "Boundary: nil status (no status available) is not a death." - (should-not (cj/--telega-server-death-p nil))) - -(ert-deftest test-telega-config-death-p-non-integer-is-not-death () - "Error: a non-integer status returns nil rather than signalling. -`process-exit-status' is documented to return an integer, but this runs -inside telega's sentinel where an error would disrupt telega's own cleanup." - (should-not (cj/--telega-server-death-p "segfault")) - (should-not (cj/--telega-server-death-p 'exited))) - -;; -- cj/--telega-server-exit-status ------------------------------------------ - -(ert-deftest test-telega-config-exit-status-nil-for-non-process () - "Error: a nil or non-process argument yields nil, not a signal. -The sentinel hands us whatever it has; a bad object must not break telega." - (should-not (cj/--telega-server-exit-status nil)) - (should-not (cj/--telega-server-exit-status "not-a-process"))) - -;; -- cj/--telega-server-death-body ------------------------------------------- - -(ert-deftest test-telega-config-death-body-names-status-and-effect () - "Normal: the body carries the status and says coverage is affected. -The status distinguishes a segfault from a clean kill; the effect is why -the reader should care." - (let ((body (cj/--telega-server-death-body 11 "segmentation fault\n"))) - (should (string-match-p "11" body)) - (should (string-match-p "Telegram" body)))) - -(ert-deftest test-telega-config-death-body-strips-trailing-newline () - "Boundary: a sentinel event string ends in a newline; it must not survive. -A trailing newline in a desktop notification body renders as dead space." - (let ((body (cj/--telega-server-death-body 11 "segmentation fault\n"))) - (should-not (string-suffix-p "\n" body)))) - -(ert-deftest test-telega-config-death-body-handles-empty-event () - "Boundary: an empty or nil event still produces a usable body." - (should (stringp (cj/--telega-server-death-body 11 nil))) - (should (stringp (cj/--telega-server-death-body 11 ""))) - (should (string-match-p "11" (cj/--telega-server-death-body 11 nil)))) - -(ert-deftest test-telega-config-death-body-handles-unicode-event () - "Boundary: a non-ASCII event string passes through intact." - (let ((body (cj/--telega-server-death-body 1 "ошибка сервера\n"))) - (should (string-match-p "ошибка" body)))) - -;; -- cj/--telega-server-notify-death (the advice) ---------------------------- - -(defmacro test-telega-config--with-status (status captured &rest body) - "Run BODY with the exit status forced to STATUS. -Notification calls are captured into CAPTURED as (TITLE . BODY) pairs." - (declare (indent 2)) - `(let ((,captured nil)) - (cl-letf (((symbol-function 'cj/--telega-server-exit-status) - (lambda (&rest _) ,status)) - ((symbol-function 'cj/--telega-server-send-notification) - (lambda (title body) (push (cons title body) ,captured)))) - ,@body))) - -(ert-deftest test-telega-config-notify-fires-on-abnormal-exit () - "Normal: an abnormal exit sends exactly one notification." - (test-telega-config--with-status 11 sent - (cj/--telega-server-notify-death nil "segmentation fault\n") - (should (= 1 (length sent))) - (should (string-match-p "telega" (downcase (car (car sent))))))) - -(ert-deftest test-telega-config-notify-silent-on-clean-exit () - "Boundary: a clean exit sends nothing. -Deliberately quitting telega must not page." - (test-telega-config--with-status 0 sent - (cj/--telega-server-notify-death nil "finished\n") - (should-not sent))) - -(ert-deftest test-telega-config-notify-silent-without-status () - "Boundary: no recoverable status sends nothing rather than a bare alert." - (test-telega-config--with-status nil sent - (cj/--telega-server-notify-death nil "gone\n") - (should-not sent))) - -(ert-deftest test-telega-config-notify-contains-notifier-errors () - "Error: a failing notifier must not escape into telega's sentinel. -This runs as :after advice on `telega-server--sentinel'; an error here -would abort telega's own status handling and its relogin path." - (cl-letf (((symbol-function 'cj/--telega-server-exit-status) - (lambda (&rest _) 11)) - ((symbol-function 'cj/--telega-server-send-notification) - (lambda (&rest _) (error "notifier unavailable")))) - (should (progn (cj/--telega-server-notify-death nil "segfault\n") t)))) - -(ert-deftest test-telega-config-notify-advice-is-named-and-removable () - "Normal: the sentinel advice is installed by name, so it can be removed. -An anonymous lambda can't be `advice-remove'd by reference, which strands -the old advice in a live daemon after the source stops installing it." - (should (fboundp 'cj/--telega-server-notify-death)) - (should (symbolp 'cj/--telega-server-notify-death))) - -(provide 'test-telega-config--server-death) -;;; test-telega-config--server-death.el ends here diff --git a/tests/test-telega-config.el b/tests/test-telega-config.el deleted file mode 100644 index 54a601c9..00000000 --- a/tests/test-telega-config.el +++ /dev/null @@ -1,58 +0,0 @@ -;;; test-telega-config.el --- Tests for Telegram (telega) module wiring -*- lexical-binding: t; -*- - -;;; Commentary: -;; Lightweight asserts that the module loads, exposes the launcher, -;; sets the docker preference, and registers the C-; G keybinding. -;; The bulk of telega.el's behaviour is owned upstream; the tests -;; here only cover what this config wires. - -;;; Code: - -(require 'ert) - -(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory)) -(require 'telega-config) - -(ert-deftest test-telega-config-loads-cleanly () - "Normal: module loads without errors and `provide's its feature." - (should (featurep 'telega-config))) - -(ert-deftest test-telega-config-launcher-binding-is-telega () - "Normal: =C-; T= invokes the launcher wrapper, which routes to -`telega' when installed or signals a helpful user-error otherwise. - -Was =C-; G= when `T' was contested between org-table and transcription -menus; both have moved (org-table flattened under `C-; O', -transcription cleared to M-x), so the natural mnemonic is free." - (should (eq (keymap-lookup cj/custom-keymap "T") #'cj/telega))) - -(ert-deftest test-telega-config-launcher-without-package-signals-user-error () - "Error: with telega absent, the launcher signals a `user-error' that -mentions the recovery path instead of falling through to the autoload -stub's cryptic load-file failure." - (cl-letf (((symbol-function 'featurep) - (lambda (sym &optional _sub) - (and (not (eq sym 'telega)) t))) - ((symbol-function 'locate-library) - (lambda (lib &rest _) (unless (equal lib "telega") t)))) - (let* ((err (should-error (cj/telega) :type 'user-error)) - (msg (error-message-string err))) - (should (string-match-p "telega not installed" msg)) - (should (string-match-p "setup-telega\\.sh\\|package-install" msg))))) - -(ert-deftest test-telega-config-launcher-with-package-calls-telega () - "Normal: with telega loadable, the launcher delegates to `telega'." - (let (called) - (cl-letf (((symbol-function 'featurep) - (lambda (sym &optional _sub) (eq sym 'telega))) - ;; The pinned image is a local build; treat it as present so - ;; this test stays about delegation, not the image check. - ((symbol-function 'cj/--telega-docker-image-present-p) - (lambda (_) t)) - ((symbol-function 'telega) - (lambda (&rest _) (setq called t)))) - (cj/telega)) - (should called))) - -(provide 'test-telega-config) -;;; test-telega-config.el ends here |
