refactor(org-agenda): extract the agenda base-file list

The fixed base list (inbox, schedule, and the three calendars) was spelled out as a literal in cj/--org-agenda-scan-files, cj/todo-list-single-project, and the chime initializer. Extract cj/--org-agenda-base-files so adding a calendar source is a one-place change; the single-project view prepends its todo.org with cons. Adds a test for the helper's contents and order.

1 files changed, 36 insertions, 0 deletions

diff --git a/tests/test-org-agenda-config--base-files.el b/tests/test-org-agenda-config--base-files.el
new file mode 100644
index 000000000..c6939b4d7
--- /dev/null
+++ b/tests/test-org-agenda-config--base-files.el
@@ -0,0 +1,36 @@
+;;; test-org-agenda-config--base-files.el --- Tests for the agenda base-file helper -*- lexical-binding: t; -*-
+
+;;; Commentary:
+;; cj/--org-agenda-base-files is the single source of the fixed agenda base list
+;; (inbox, schedule, and the three calendars) that was previously spelled out as
+;; a literal in three places.  The path vars are special (defvar'd in
+;; user-constants), so they can be dynamically bound here.
+
+;;; Code:
+
+(require 'ert)
+
+(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
+(require 'org-agenda-config)
+
+(ert-deftest test-org-agenda-base-files-returns-fixed-list-in-order ()
+  "Normal: returns inbox, schedule, gcal, pcal, dcal in that order."
+  (let ((inbox-file "/i")
+        (schedule-file "/s")
+        (gcal-file "/g")
+        (pcal-file "/p")
+        (dcal-file "/d"))
+    (should (equal (cj/--org-agenda-base-files)
+                   '("/i" "/s" "/g" "/p" "/d")))))
+
+(ert-deftest test-org-agenda-base-files-reflects-current-values ()
+  "Boundary: the helper reads the vars at call time (not a captured snapshot)."
+  (let ((inbox-file "first")
+        (schedule-file "x") (gcal-file "x") (pcal-file "x") (dcal-file "x"))
+    (should (equal (car (cj/--org-agenda-base-files)) "first"))
+    (setq inbox-file "second")
+    (should (equal (car (cj/--org-agenda-base-files)) "second"))
+    (should (= (length (cj/--org-agenda-base-files)) 5))))
+
+(provide 'test-org-agenda-config--base-files)
+;;; test-org-agenda-config--base-files.el ends here