diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-25 18:29:32 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-25 18:29:32 -0500 |
| commit | 9b1d563cad3a1484d294896ddbf09689d95b3b5b (patch) | |
| tree | 1796681a551807cf233de2417f484069c487bef9 /tests | |
| parent | 937be691cd921eeaebac0349782d985edba820cd (diff) | |
| download | dotemacs-9b1d563cad3a1484d294896ddbf09689d95b3b5b.tar.gz dotemacs-9b1d563cad3a1484d294896ddbf09689d95b3b5b.zip | |
feat(system-defaults): warn once when Customize tries to save
custom-file points at a throwaway temp file so Customize edits never persist — deliberate, since config lives in Elisp, but silent. A user who clicks "Save for Future Sessions" loses the edit on exit with no hint. I advise custom-save-all (the chokepoint both customize-save-variable and the Customize button funnel through) with a one-shot :before warning that explains the discard and points at the Elisp init files. The advice removes itself after firing, so it warns once per session, and the body never runs at load, so startup stays quiet.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-system-defaults.el | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/tests/test-system-defaults.el b/tests/test-system-defaults.el index bc3694db..3c5e5977 100644 --- a/tests/test-system-defaults.el +++ b/tests/test-system-defaults.el @@ -64,5 +64,25 @@ they are actually wired onto the minibuffer hooks." (should (memq 'cj/minibuffer-setup-hook minibuffer-setup-hook)) (should (memq 'cj/minibuffer-exit-hook minibuffer-exit-hook))))) +;;; Customize-save warning + +(ert-deftest test-system-defaults-customize-save-warns-once () + "Normal: the first custom-save-all warns; the second does not (one-shot). +Customize writes land in a throwaway custom-file, so the user must be told +their edit will not persist. The advice removes itself after warning once." + (test-system-defaults--with-load-environment + (let ((warnings '())) + (cl-letf (((symbol-function 'display-warning) + (lambda (group &rest _) (push group warnings))) + ((symbol-function 'custom-save-all) #'ignore)) + (test-system-defaults--load) + ;; No warning merely from loading the module. + (should (null warnings)) + (custom-save-all) + (should (equal warnings '(cj/system-defaults))) + ;; Second save must not warn again. + (custom-save-all) + (should (equal warnings '(cj/system-defaults))))))) + (provide 'test-system-defaults) ;;; test-system-defaults.el ends here |