diff options
| author | Craig Jennings <c@cjennings.net> | 2026-06-16 08:37:46 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-06-16 08:37:46 -0500 |
| commit | b10a1b7a33772c744abfd11ff1e4aef8b33e519b (patch) | |
| tree | 219bd11c4d2dacae4160c07ac73f251ce0fca0e1 /todo.org | |
| parent | c96c1e9f94f52876b3a8c6ab8e35a00e5f556f3d (diff) | |
| download | dotemacs-b10a1b7a33772c744abfd11ff1e4aef8b33e519b.tar.gz dotemacs-b10a1b7a33772c744abfd11ff1e4aef8b33e519b.zip | |
fix(theme-studio): make the color picker stand out from the page
The picker panel's background (#161412) sat a few shades off the page background (#0d0b0a), so it was hard to tell apart from the page. I gave it the studio's gold accent border (#e8bd30) and lifted the background to #1f1c19, both already used in the toolbar chrome, so the panel reads as a distinct surface. The #pickertest gate asserts the accent border and a per-channel background lift of at least 12 over the page, so the distinction can't quietly regress.
Diffstat (limited to 'todo.org')
| -rw-r--r-- | todo.org | 15 |
1 files changed, 14 insertions, 1 deletions
@@ -4240,11 +4240,13 @@ Rule taxonomy captured in [[file:docs/design/theme-studio-face-rules.org][docs/d Bake into the tool (a lint surfaced in the UI) or run as a build-time check (seeds vs live deffaces via emacsclient). -** TODO [#C] theme-studio picker panel blends into the page :bug:quick:solo:studio: +** DONE [#C] theme-studio picker panel blends into the page :bug:quick:solo:studio: +CLOSED: [2026-06-16 Tue] :PROPERTIES: :LAST_REVIEWED: 2026-06-11 :END: Craig, 2026-06-11 manual-test walk: the color picker's background is hard to distinguish from the page background. Give the picker panel a visibly distinct background or a highlighted border so it stands out. Pin with a gate asserting the picker element carries the distinct style. +Done 2026-06-16: the picker now carries the gold accent border (#e8bd30) and a lighter background (#1f1c19 vs the page's #0d0b0a). The #pickertest gate asserts the accent border and a per-channel background lift of ≥12 over the page, so the distinction can't silently regress. ** TODO [#C] theme-studio: restrict the cursor row to its background :bug:studio: The UI table gives the cursor face the full control set (fg, B/I/U/S, box), but Emacs only honors the cursor face's :background. Its shape is cursor-type, not a face attribute, so every other control on that row is a no-op once the theme loads. Restrict the cursor row to just its background swatch so the studio doesn't present controls Emacs drops. @@ -4579,6 +4581,17 @@ What we're verifying: with the mu4e modes excluded from global font-lock, mu4e's - Open mu4e, look at the headers list and the main menu - Open a message and read the body Expected: headers list shows unread/flagged/date/subject in their theme colors (mu4e-unread-face gold, mu4e-header-face green, etc.); the main menu and the message-view headers (From/To/Subject) are themed; the message body still renders correctly (gnus does the body, so it's unaffected). NOTE: a plain "g" refresh in an already-open *mu4e-headers* won't fix it on its own unless font-lock is off there; a restart is the reliable check. +*** VERIFY theme-studio gnus view package themes the article headers +What we're verifying: gnus is now its own view package in theme-studio (it drives the mu4e article view), so the bright-green article headers can be themed and exported. #gnustest confirms the package is registered and its preview emits only real gnus faces; this is the visual read plus the live-green retirement. +- Reload theme-studio (or make theme-studio-open) +- Pick "gnus (mu4e article view)" from the view dropdown (sits among the g entries) +- Confirm the preview shows a header block, an emphasized body, an 11-level quoted reply chain, and a signature +- Theme a few gnus faces (e.g. gnus-header-name, gnus-header-from, gnus-cite-1) to obvious colors, export to WIP.json, then deploy +#+begin_src sh :results output +make -C /home/cjennings/.emacs.d deploy-wip +#+end_src +- Restart Emacs (or reload the theme), reopen a mu4e message +Expected: the studio preview renders each gnus face in its theme color; after export + deploy, the *mu4e-article* From/Subject/To/Date headers show the themed colors instead of the gnus green defaults. *** VERIFY theme-studio markdown preview reads like a real README What we're verifying: selecting markdown-mode in the view dropdown shows a realistic README (not the generic face-name list), and the markdown faces render legibly in context. #mdtest already confirms the wiring + that every element's face is real; this is the visual read. - Reload theme-studio (or make theme-studio-open) |
