aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--modules/keyboard-compat.el7
-rw-r--r--tests/test-keyboard-compat-setup.el8
2 files changed, 13 insertions, 2 deletions
diff --git a/modules/keyboard-compat.el b/modules/keyboard-compat.el
index 9395b9c8..b72362e7 100644
--- a/modules/keyboard-compat.el
+++ b/modules/keyboard-compat.el
@@ -45,8 +45,11 @@ This runs after init to override any package settings."
(define-key input-decode-map "\eOC" [right])
(define-key input-decode-map "\eOD" [left])))
-;; Run after init completes to override any package settings
-(add-hook 'emacs-startup-hook #'cj/keyboard-compat-terminal-setup)
+;; `input-decode-map' is terminal-local, and a daemon's `emacs-startup-hook'
+;; runs once with no tty, so a startup-hook registration never reaches the
+;; `emacsclient -t' frames that need it. `tty-setup-hook' runs for each new
+;; tty frame (daemon and non-daemon alike), which is where the decodings belong.
+(add-hook 'tty-setup-hook #'cj/keyboard-compat-terminal-setup)
;; Icon-rendering functions return blank on terminal frames so unicode
;; artifacts don't show up. The check runs per call against the selected
diff --git a/tests/test-keyboard-compat-setup.el b/tests/test-keyboard-compat-setup.el
index 1c5cd434..a3e6f441 100644
--- a/tests/test-keyboard-compat-setup.el
+++ b/tests/test-keyboard-compat-setup.el
@@ -61,6 +61,14 @@ string can return a meta-prefix event count rather than nil.)"
(cj/keyboard-compat-terminal-setup)
(should (equal input-decode-map (make-sparse-keymap)))))
+(ert-deftest test-keyboard-compat-terminal-setup-on-tty-setup-hook ()
+ "Normal: terminal setup is registered on `tty-setup-hook', which runs for each
+new tty frame. `input-decode-map' is terminal-local, so `emacs-startup-hook'
+\(once, at daemon start, with no tty) leaves every later `emacsclient -t' frame
+without the arrow-key decodings. The GUI half already frame-scopes itself."
+ (should (memq 'cj/keyboard-compat-terminal-setup tty-setup-hook))
+ (should-not (memq 'cj/keyboard-compat-terminal-setup emacs-startup-hook)))
+
;; -------------------------- cj/keyboard-compat-gui-setup ---------------------
(defmacro test-kbc--gui (gui-p &rest body)