diff options
| -rw-r--r-- | modules/ui-theme.el | 9 | ||||
| -rw-r--r-- | tests/test-ui-theme-commands.el | 10 |
2 files changed, 16 insertions, 3 deletions
diff --git a/modules/ui-theme.el b/modules/ui-theme.el index 2df37000..a7873b9a 100644 --- a/modules/ui-theme.el +++ b/modules/ui-theme.el @@ -64,11 +64,14 @@ directory that is sync'd across machines with this configuration." :type 'file :group 'cj/ui-theme) -(defcustom fallback-theme-name "modus-vivendi" +(defcustom fallback-theme-name "dupre" "The name of the theme to fallback on. This is used when there's no file, or the theme name doesn't match -any of the installed themes. This should be a built-in theme. If theme name is -`nil', there will be no theme." +any of the installed themes. It must be available wherever this config is +loaded, since the fallback has no further fallback. dupre is bundled in +themes/ and carries the dimming colors chosen for this config, so it is the +default; a built-in theme like modus-vivendi works too but has no chosen +dimming colors. If theme name is `nil', there will be no theme." :type 'string :group 'cj/ui-theme) diff --git a/tests/test-ui-theme-commands.el b/tests/test-ui-theme-commands.el index f5f57c31..55facc17 100644 --- a/tests/test-ui-theme-commands.el +++ b/tests/test-ui-theme-commands.el @@ -34,6 +34,16 @@ (fallback-theme-name "modus-vivendi")) (should (equal "modus-vivendi" (cj/get-active-theme-name))))) +;;; fallback-theme-name default + +(ert-deftest test-ui-theme-default-fallback-is-bundled-dupre () + "Normal: the default fallback theme is dupre, the config's bundled theme. +modus-vivendi ships with Emacs but has no chosen dimming colors; dupre is +bundled in themes/, so it is available on every machine that loads this +config and is the right default fallback. Its loadability is covered by +test-dupre-theme.el." + (should (equal "dupre" (default-value 'fallback-theme-name)))) + ;;; cj/save-theme-to-file (ert-deftest test-ui-theme-save-writes-active-name-to-file () |