aboutsummaryrefslogtreecommitdiff
path: root/modules/eww-config.el
diff options
context:
space:
mode:
Diffstat (limited to 'modules/eww-config.el')
-rw-r--r--modules/eww-config.el16
1 files changed, 11 insertions, 5 deletions
diff --git a/modules/eww-config.el b/modules/eww-config.el
index 066fae989..ff7ddc211 100644
--- a/modules/eww-config.el
+++ b/modules/eww-config.el
@@ -32,6 +32,8 @@
(require 'cl-lib)
+(declare-function eww-add-bookmark "eww")
+
(defgroup my-eww-user-agent nil
"EWW-only User-Agent management."
:group 'eww)
@@ -42,6 +44,13 @@
:type 'string
:group 'my-eww-user-agent)
+;; This file is lexical-binding, so `let'-binding url.el's special var below
+;; needs it declared special at compile time. Without this the byte-compiled
+;; advice binds `url-request-extra-headers' lexically and the injected
+;; User-Agent never reaches `url-retrieve' (it reads the dynamic value) -- the
+;; UA injection silently no-ops in compiled production, and the test sees nil.
+(defvar url-request-extra-headers)
+
(defun my-eww--inject-user-agent (orig-fun &rest args)
"Set a User-Agent only when making requests from an EWW buffer."
(if (derived-mode-p 'eww-mode)
@@ -119,11 +128,8 @@
(unless (derived-mode-p 'eww-mode)
(user-error "Not in EWW buffer"))
(when-let ((title (plist-get eww-data :title)))
- (let ((eww-bookmarks-directory (expand-file-name "eww-bookmarks" user-emacs-directory)))
- (unless (file-exists-p eww-bookmarks-directory)
- (make-directory eww-bookmarks-directory t))
- (eww-add-bookmark)
- (message "Bookmarked: %s" title))))
+ (eww-add-bookmark)
+ (message "Bookmarked: %s" title)))
(defun cj/eww-copy-url ()
"Copy the current EWW URL to clipboard."