blob: 0db9f34545d049fd3e35f9a5a47cafd60850b74f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
;;; test-calendar-sync--expand-daily.el --- Tests for calendar-sync--expand-daily -*- lexical-binding: t; -*-
;;; Commentary:
;; Characterization tests for calendar-sync--expand-daily.
;; Captures current behavior before refactoring into unified expand function.
;; Uses dynamic timestamps to avoid hardcoded dates.
;;; Code:
(require 'ert)
(require 'testutil-calendar-sync)
(require 'calendar-sync)
;;; Normal Cases
(ert-deftest test-calendar-sync--expand-daily-normal-generates-occurrences ()
"Test expanding daily event generates occurrences within range."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "Daily Standup"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
;; ~365 days future + ~90 days past = ~456 days of occurrences
(should (> (length occurrences) 300))
(should (< (length occurrences) 500))))
(ert-deftest test-calendar-sync--expand-daily-normal-preserves-time ()
"Test that each occurrence preserves the original event time."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 14 30))
(end-date (test-calendar-sync-time-days-from-now 1 15 30))
(base-event (list :summary "Afternoon Check"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1))
(range (test-calendar-sync-narrow-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (> (length occurrences) 0))
(dolist (occ occurrences)
(let ((s (plist-get occ :start)))
(should (= (nth 3 s) 14))
(should (= (nth 4 s) 30))))))
(ert-deftest test-calendar-sync--expand-daily-normal-interval-two ()
"Test expanding every-other-day event."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 9 0))
(end-date (test-calendar-sync-time-days-from-now 1 10 0))
(base-event (list :summary "Every Other Day"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 2))
(range (test-calendar-sync-narrow-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
;; 30 days / 2 = ~15 occurrences
(should (>= (length occurrences) 12))
(should (<= (length occurrences) 18))))
(ert-deftest test-calendar-sync--expand-daily-normal-consecutive-dates-increase ()
"Test that occurrences are on consecutive dates spaced by interval."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "Daily"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 3))
(range (test-calendar-sync-narrow-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(when (> (length occurrences) 1)
(let ((prev (plist-get (car occurrences) :start)))
(dolist (occ (cdr occurrences))
(let ((curr (plist-get occ :start)))
;; Days between consecutive occurrences should be ~3
(let ((days (test-calendar-sync-days-between prev curr)))
(should (>= days 2.5))
(should (<= days 3.5)))
(setq prev curr)))))))
;;; Boundary Cases
(ert-deftest test-calendar-sync--expand-daily-boundary-count-limits-occurrences ()
"Test that COUNT limits the total number of occurrences."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "Limited"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1 :count 7))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (= (length occurrences) 7))))
(ert-deftest test-calendar-sync--expand-daily-boundary-until-limits-occurrences ()
"Test that UNTIL date stops expansion."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(until-date (test-calendar-sync-time-date-only 15))
(base-event (list :summary "Until-Limited"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1 :until until-date))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
;; ~14 days worth of daily occurrences
(should (>= (length occurrences) 12))
(should (<= (length occurrences) 16))))
(ert-deftest test-calendar-sync--expand-daily-boundary-respects-date-range ()
"Test that occurrences are within or at the date range boundaries."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "Ranged"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1))
(range (test-calendar-sync-narrow-range))
(occurrences (calendar-sync--expand-daily base-event rrule range))
(range-start (nth 0 range))
;; Add 1 day buffer — date-in-range-p checks date portion only
(range-end-padded (time-add (nth 1 range) 86400)))
(dolist (occ occurrences)
(let* ((s (plist-get occ :start))
(occ-time (test-calendar-sync-date-to-time-value s)))
(should (time-less-p range-start occ-time))
(should (time-less-p occ-time range-end-padded))))))
(ert-deftest test-calendar-sync--expand-daily-boundary-count-one-returns-single ()
"Test that COUNT=1 returns exactly one occurrence."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "Once"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1 :count 1))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (= (length occurrences) 1))))
(ert-deftest test-calendar-sync--expand-daily-boundary-preserves-summary ()
"Test that each occurrence carries the original summary."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(end-date (test-calendar-sync-time-days-from-now 1 11 0))
(base-event (list :summary "My Event"
:start start-date
:end end-date
:location "Room 5"))
(rrule (list :freq 'daily :interval 1 :count 3))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(dolist (occ occurrences)
(should (equal (plist-get occ :summary) "My Event")))))
;;; Error Cases
(ert-deftest test-calendar-sync--expand-daily-error-past-until-returns-empty ()
"Test that UNTIL in the past produces no occurrences in future range."
(let* ((start-date (test-calendar-sync-time-days-ago 100 10 0))
(end-date (test-calendar-sync-time-days-ago 100 11 0))
(until-date (test-calendar-sync-time-date-only-ago 50))
(base-event (list :summary "Past"
:start start-date
:end end-date))
(rrule (list :freq 'daily :interval 1 :until until-date))
(range (list (time-subtract (current-time) (* 30 86400))
(time-add (current-time) (* 365 86400))))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (= (length occurrences) 0))))
(ert-deftest test-calendar-sync--expand-daily-error-no-end-time-still-works ()
"Test that event without :end still generates occurrences."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(base-event (list :summary "No End" :start start-date))
(rrule (list :freq 'daily :interval 1 :count 5))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (= (length occurrences) 5))))
;;; UNTIL is inclusive (RFC 5545 3.3.10)
(ert-deftest test-calendar-sync--expand-daily-until-includes-the-until-date ()
"Boundary: an occurrence falling ON the UNTIL date is kept.
RFC 5545 3.3.10: UNTIL bounds the recurrence \"in an inclusive manner\", and
when it lines up with the recurrence that date \"becomes the last instance\".
A strict before-comparison drops it, so the last meeting of every bounded
series silently vanishes from the agenda."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(until-date (test-calendar-sync-time-date-only 5))
(base-event (list :summary "Bounded Standup" :start start-date))
(rrule (list :freq 'daily :interval 1 :until until-date))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range))
(last-start (plist-get (car (last occurrences)) :start)))
;; day+1 through day+5 inclusive = 5 occurrences.
(should (= (length occurrences) 5))
;; The final occurrence is the UNTIL date itself.
(should (equal (seq-take last-start 3) until-date))))
(ert-deftest test-calendar-sync--expand-daily-until-excludes-dates-after-it ()
"Boundary: inclusivity stops at UNTIL; the next day is not generated.
Guards the fix against over-correcting into an off-by-one the other way."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(until-date (test-calendar-sync-time-date-only 5))
(day-after (test-calendar-sync-time-date-only 6))
(base-event (list :summary "Bounded Standup" :start start-date))
(rrule (list :freq 'daily :interval 1 :until until-date))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range))
(dates (mapcar (lambda (o) (seq-take (plist-get o :start) 3)) occurrences)))
(should (member until-date dates))
(should-not (member day-after dates))))
(ert-deftest test-calendar-sync--expand-daily-until-on-start-date-yields-one ()
"Boundary: UNTIL equal to the start date yields exactly that one occurrence.
The degenerate single-instance series -- a strict comparison returns nothing
at all here, which is the same defect at its smallest."
(let* ((start-date (test-calendar-sync-time-days-from-now 1 10 0))
(until-date (test-calendar-sync-time-date-only 1))
(base-event (list :summary "One Shot" :start start-date))
(rrule (list :freq 'daily :interval 1 :until until-date))
(range (test-calendar-sync-wide-range))
(occurrences (calendar-sync--expand-daily base-event rrule range)))
(should (= (length occurrences) 1))
(should (equal (seq-take (plist-get (car occurrences) :start) 3) until-date))))
(provide 'test-calendar-sync--expand-daily)
;;; test-calendar-sync--expand-daily.el ends here
|
