blob: 114fec29372798bc80c1187ce2ebc27b5763ebbd (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
|
;;; test-gptel-tools-git-diff.el --- Tests for git_diff gptel tool -*- lexical-binding: t; -*-
;;; Commentary:
;; Tests run against real temp git repos under HOME via `process-file'.
;;; Code:
(require 'ert)
(require 'cl-lib)
(eval-and-compile
(add-to-list 'load-path (expand-file-name "tests" user-emacs-directory))
(add-to-list 'load-path (expand-file-name "gptel-tools" user-emacs-directory))
(setq load-prefer-newer t)
(unless (featurep 'gptel)
(defvar gptel-tools nil)
(defun gptel-make-tool (&rest _args) nil)
(defun gptel-get-tool (&rest _args) nil)
(provide 'gptel)))
(require 'git_diff)
;; ---------- helpers
(defun test-gptel-tools-git-diff--with-repo (fn)
"Create a temp git repo under HOME with one committed file, call FN."
(let* ((name (format ".test-gptel-tools-git-diff-%s"
(format-time-string "%s%N")))
(dir (expand-file-name name "~")))
(unwind-protect
(progn
(make-directory dir)
(let ((default-directory dir))
(call-process "git" nil nil nil "init" "--quiet")
(call-process "git" nil nil nil "config" "user.email" "test@x")
(call-process "git" nil nil nil "config" "user.name" "Test")
(with-temp-file (expand-file-name "f.txt" dir)
(insert "original\n"))
(call-process "git" nil nil nil "add" "f.txt")
(call-process "git" nil nil nil "commit" "--quiet" "-m" "initial"))
(funcall fn dir))
(when (file-exists-p dir) (delete-directory dir t)))))
;; ---------- build-args
(ert-deftest test-gptel-tools-git-diff-build-args-no-refs ()
"Normal: no refs / no file → bare diff args."
(should (equal (cj/gptel-git-diff--build-args nil nil nil)
'("-c" "color.ui=false" "diff"))))
(ert-deftest test-gptel-tools-git-diff-build-args-with-ref1 ()
"Normal: REF1 appended."
(should (equal (cj/gptel-git-diff--build-args "HEAD~1" nil nil)
'("-c" "color.ui=false" "diff" "HEAD~1"))))
(ert-deftest test-gptel-tools-git-diff-build-args-with-both-refs ()
"Normal: REF1 and REF2 both appended."
(should (equal (cj/gptel-git-diff--build-args "HEAD~1" "HEAD" nil)
'("-c" "color.ui=false" "diff" "HEAD~1" "HEAD"))))
(ert-deftest test-gptel-tools-git-diff-build-args-with-file ()
"Normal: FILE appended after `--'."
(should (equal (cj/gptel-git-diff--build-args nil nil "foo.txt")
'("-c" "color.ui=false" "diff" "--" "foo.txt"))))
(ert-deftest test-gptel-tools-git-diff-build-args-boundary-empty-strings ()
"Boundary: empty-string REF/FILE values are ignored."
(should (equal (cj/gptel-git-diff--build-args "" "" "")
'("-c" "color.ui=false" "diff"))))
;; ---------- truncate
(ert-deftest test-gptel-tools-git-diff-truncate-under-cap ()
"Normal: short input returns unchanged."
(should (equal (cj/gptel-git-diff--truncate "small diff") "small diff")))
(ert-deftest test-gptel-tools-git-diff-truncate-over-cap ()
"Boundary: output exceeding the cap is truncated with a marker."
(let* ((cap cj/gptel-git-diff--max-output-bytes)
(huge (make-string (+ cap 1000) ?x))
(out (cj/gptel-git-diff--truncate huge)))
(should (string-match-p "\\[truncated:" out))
(should (> (length huge) (length out)))))
;; ---------- validate-path
(ert-deftest test-gptel-tools-git-diff-validate-path-normal ()
"Normal: validator accepts a git working tree."
(test-gptel-tools-git-diff--with-repo
(lambda (dir)
(should (equal (cj/gptel-git-diff--validate-path dir) dir)))))
(ert-deftest test-gptel-tools-git-diff-validate-path-error-outside-home ()
"Error: path outside HOME signals."
(should-error (cj/gptel-git-diff--validate-path "/etc")))
(ert-deftest test-gptel-tools-git-diff-validate-path-error-not-a-repo ()
"Error: non-git directory signals."
(let ((dir (make-temp-file
(expand-file-name ".test-gptel-tools-git-diff-" "~") t)))
(unwind-protect
(should-error (cj/gptel-git-diff--validate-path dir))
(when (file-exists-p dir) (delete-directory dir t)))))
(ert-deftest test-gptel-tools-git-diff-validate-path-error-not-a-directory ()
"Error: file paths are rejected."
(let ((file (make-temp-file
(expand-file-name ".test-gptel-tools-git-diff-file-" "~"))))
(unwind-protect
(should-error (cj/gptel-git-diff--validate-path file))
(when (file-exists-p file) (delete-file file)))))
(ert-deftest test-gptel-tools-git-diff-validate-path-error-symlink-outside-home ()
"Error: symlinked directories resolving outside HOME are rejected."
(let ((link (expand-file-name
(format ".test-gptel-tools-git-diff-link-%s"
(format-time-string "%s%N"))
"~")))
(unwind-protect
(progn
(make-symbolic-link "/tmp" link t)
(should-error (cj/gptel-git-diff--validate-path link)))
(when (file-symlink-p link) (delete-file link)))))
;; ---------- run
(ert-deftest test-gptel-tools-git-diff-run-no-changes ()
"Boundary: a clean tree with no refs returns the no-diff marker."
(test-gptel-tools-git-diff--with-repo
(lambda (dir)
(let ((out (cj/gptel-git-diff--run dir)))
(should (string-match-p "No diff" out))))))
(ert-deftest test-gptel-tools-git-diff-run-unstaged-change ()
"Normal: an unstaged edit appears as a real diff."
(test-gptel-tools-git-diff--with-repo
(lambda (dir)
(with-temp-file (expand-file-name "f.txt" dir)
(insert "changed\n"))
(let ((out (cj/gptel-git-diff--run dir)))
(should (string-match-p "^-original" out))
(should (string-match-p "^\\+changed" out))))))
(ert-deftest test-gptel-tools-git-diff-run-narrow-to-file ()
"Normal: FILE argument narrows the diff."
(test-gptel-tools-git-diff--with-repo
(lambda (dir)
(with-temp-file (expand-file-name "f.txt" dir)
(insert "changed\n"))
(with-temp-file (expand-file-name "g.txt" dir)
(insert "second file\n"))
(let ((out (cj/gptel-git-diff--run dir nil nil "f.txt")))
(should (string-match-p "f.txt" out))
(should-not (string-match-p "g.txt" out))))))
(ert-deftest test-gptel-tools-git-diff-run-error-on-bad-ref ()
"Error: git diff exits other than 0/1 are surfaced."
(test-gptel-tools-git-diff--with-repo
(lambda (dir)
(should-error (cj/gptel-git-diff--run dir "does-not-exist")))))
(provide 'test-gptel-tools-git-diff)
;;; test-gptel-tools-git-diff.el ends here
|
