blob: c0503039a3c7e28adc7709027e2908d41e60cbb5 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
;;; test-gptel-tools-git-log.el --- Tests for git_log gptel tool -*- lexical-binding: t; -*-
;;; Commentary:
;; Tests run against real temp git repos under HOME via `process-file'.
;;; Code:
(require 'ert)
(require 'cl-lib)
(eval-and-compile
(add-to-list 'load-path (expand-file-name "tests" user-emacs-directory))
(add-to-list 'load-path (expand-file-name "gptel-tools" user-emacs-directory))
(setq load-prefer-newer t)
(unless (featurep 'gptel)
(defvar gptel-tools nil)
(defun gptel-make-tool (&rest _args) nil)
(defun gptel-get-tool (&rest _args) nil)
(provide 'gptel)))
(require 'git_log)
;; ---------- helpers
(defun test-gptel-tools-git-log--with-repo (commit-count fn)
"Create a temp git repo under HOME with COMMIT-COUNT empty commits.
Call FN with the absolute path, clean up after."
(let* ((name (format ".test-gptel-tools-git-log-%s"
(format-time-string "%s%N")))
(dir (expand-file-name name "~")))
(unwind-protect
(progn
(make-directory dir)
(let ((default-directory dir))
(call-process "git" nil nil nil "init" "--quiet")
(call-process "git" nil nil nil "config" "user.email" "test@x")
(call-process "git" nil nil nil "config" "user.name" "Test")
(dotimes (i commit-count)
(let ((process-environment
(append
(list "GIT_AUTHOR_DATE=2000-01-01T00:00:00+0000"
"GIT_COMMITTER_DATE=2000-01-01T00:00:00+0000")
process-environment)))
(call-process "git" nil nil nil "commit" "--allow-empty"
"--quiet" "-m" (format "commit %d" i)))))
(funcall fn dir))
(when (file-exists-p dir) (delete-directory dir t)))))
;; ---------- effective-count
(ert-deftest test-gptel-tools-git-log-effective-count-defaults-on-nil ()
"Boundary: nil N → default count."
(should (= (cj/gptel-git-log--effective-count nil)
cj/gptel-git-log--default-count)))
(ert-deftest test-gptel-tools-git-log-effective-count-defaults-on-non-integer ()
"Boundary: non-integer N → default count."
(should (= (cj/gptel-git-log--effective-count "ten")
cj/gptel-git-log--default-count))
(should (= (cj/gptel-git-log--effective-count 0.5)
cj/gptel-git-log--default-count)))
(ert-deftest test-gptel-tools-git-log-effective-count-clamps-low ()
"Boundary: N below 1 → default count."
(should (= (cj/gptel-git-log--effective-count 0)
cj/gptel-git-log--default-count))
(should (= (cj/gptel-git-log--effective-count -5)
cj/gptel-git-log--default-count)))
(ert-deftest test-gptel-tools-git-log-effective-count-caps-high ()
"Boundary: N above max → max."
(should (= (cj/gptel-git-log--effective-count 1000)
cj/gptel-git-log--max-count)))
(ert-deftest test-gptel-tools-git-log-effective-count-normal ()
"Normal: a valid N passes through."
(should (= (cj/gptel-git-log--effective-count 5) 5)))
;; ---------- validate-path
(ert-deftest test-gptel-tools-git-log-validate-path-normal ()
"Normal: validator accepts a git working tree."
(test-gptel-tools-git-log--with-repo
1
(lambda (dir)
(should (equal (cj/gptel-git-log--validate-path dir) dir)))))
(ert-deftest test-gptel-tools-git-log-validate-path-error-outside-home ()
"Error: path outside HOME signals."
(should-error (cj/gptel-git-log--validate-path "/etc")))
(ert-deftest test-gptel-tools-git-log-validate-path-error-not-a-repo ()
"Error: directory outside any git working tree signals."
(let ((dir (make-temp-file
(expand-file-name ".test-gptel-tools-git-log-" "~") t)))
(unwind-protect
(should-error (cj/gptel-git-log--validate-path dir))
(when (file-exists-p dir) (delete-directory dir t)))))
(ert-deftest test-gptel-tools-git-log-validate-path-error-not-a-directory ()
"Error: file paths are rejected."
(let ((file (make-temp-file
(expand-file-name ".test-gptel-tools-git-log-file-" "~"))))
(unwind-protect
(should-error (cj/gptel-git-log--validate-path file))
(when (file-exists-p file) (delete-file file)))))
(ert-deftest test-gptel-tools-git-log-validate-path-error-symlink-outside-home ()
"Error: symlinked directories resolving outside HOME are rejected."
(let ((link (expand-file-name
(format ".test-gptel-tools-git-log-link-%s"
(format-time-string "%s%N"))
"~")))
(unwind-protect
(progn
(make-symbolic-link "/tmp" link t)
(should-error (cj/gptel-git-log--validate-path link)))
(when (file-symlink-p link) (delete-file link)))))
;; ---------- run
(ert-deftest test-gptel-tools-git-log-run-default-count ()
"Normal: default count limits output to that many commits."
(test-gptel-tools-git-log--with-repo
30
(lambda (dir)
(let* ((out (cj/gptel-git-log--run dir))
(lines (split-string (string-trim out) "\n")))
(should (= (length lines) cj/gptel-git-log--default-count))))))
(ert-deftest test-gptel-tools-git-log-run-honors-n ()
"Normal: an explicit N limits output to N commits."
(test-gptel-tools-git-log--with-repo
10
(lambda (dir)
(let* ((out (cj/gptel-git-log--run dir 3))
(lines (split-string (string-trim out) "\n")))
(should (= (length lines) 3))))))
(ert-deftest test-gptel-tools-git-log-run-since-no-match ()
"Boundary: --since filter with no matching commits returns marker."
(test-gptel-tools-git-log--with-repo
1
(lambda (dir)
(let ((out (cj/gptel-git-log--run dir 10 "2001-01-01")))
(should (string-match-p "No commits" out))))))
(ert-deftest test-gptel-tools-git-log-run-error-on-git-log-failure ()
"Error: non-zero git log exits are surfaced."
(test-gptel-tools-git-log--with-repo
1
(lambda (dir)
(cl-letf (((symbol-function 'process-file)
(lambda (program infile destination display &rest args)
(if (member "log" args)
(progn
(when (bufferp destination)
(with-current-buffer destination (insert "bad log")))
2)
(apply #'call-process program infile destination display args)))))
(should-error (cj/gptel-git-log--run dir))))))
(ert-deftest test-gptel-tools-git-log-run-empty-repo ()
"Boundary: a repo with no commits returns the empty-result marker."
(let* ((name (format ".test-gptel-tools-git-log-empty-%s"
(format-time-string "%s%N")))
(dir (expand-file-name name "~")))
(unwind-protect
(progn
(make-directory dir)
(let ((default-directory dir))
(call-process "git" nil nil nil "init" "--quiet"))
;; git log on a no-commits repo errors in some versions, but
;; our wrapper turns "no commits" into the no-match marker.
(let ((res (ignore-errors (cj/gptel-git-log--run dir))))
;; Either path is acceptable: error captured (nil) or the
;; explicit "No commits matching" marker.
(should (or (null res)
(string-match-p "No commits" res)))))
(when (file-exists-p dir) (delete-directory dir t)))))
(provide 'test-gptel-tools-git-log)
;;; test-gptel-tools-git-log.el ends here
|
