blob: f15559d7b6d71cdf3b0ddc41b7151a954910d26f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
|
;;; test-system-commands-resolve-and-run.el --- Tests for system-commands helpers + wrappers -*- lexical-binding: t; -*-
;;; Commentary:
;; Sibling `test-system-commands-keymap.el' locks the keymap shape.
;; This file covers the runtime helpers and commands:
;;
;; cj/system-cmd--resolve
;; cj/system-cmd
;; cj/system-cmd-exit-emacs
;; cj/system-cmd-restart-emacs
;; cj/system-command-menu
;;
;; Process and prompt primitives are stubbed.
;;; Code:
(require 'ert)
(require 'cl-lib)
(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
(require 'system-commands)
;; Top-level defvars so `let' bindings reach `symbol-value' under
;; lexical scope.
(defvar test-sc-my-cmd nil
"Dynamic test var for `cj/system-cmd--resolve' symbol-resolution test.")
(defvar test-sc-empty-cmd nil
"Dynamic test var for the empty-value test.")
;;; cj/system-cmd--resolve
(ert-deftest test-system-cmd-resolve-string-trims-and-returns ()
"Normal: a non-empty string comes back trimmed with a nil symbol slot."
(let ((result (cj/system-cmd--resolve " echo hi ")))
(should (null (nth 0 result)))
(should (equal (nth 1 result) "echo hi"))
(should (equal (nth 2 result) "command"))))
(ert-deftest test-system-cmd-resolve-empty-string-errors ()
"Error: an empty string signals user-error."
(should-error (cj/system-cmd--resolve " ") :type 'user-error))
(ert-deftest test-system-cmd-resolve-symbol-uses-its-value ()
"Normal: a symbol whose value is a non-empty string round-trips."
(let ((test-sc-my-cmd "echo hello"))
(let ((result (cj/system-cmd--resolve 'test-sc-my-cmd)))
(should (eq (nth 0 result) 'test-sc-my-cmd))
(should (equal (nth 1 result) "echo hello"))
(should (equal (nth 2 result) "test-sc-my-cmd")))))
(ert-deftest test-system-cmd-resolve-symbol-with-empty-value-errors ()
"Error: a symbol whose value isn't a non-empty string signals user-error."
(let ((test-sc-empty-cmd ""))
(should-error (cj/system-cmd--resolve 'test-sc-empty-cmd) :type 'user-error)))
(ert-deftest test-system-cmd-resolve-non-string-non-symbol-errors ()
"Error: passing a number signals user-error."
(should-error (cj/system-cmd--resolve 42) :type 'user-error))
;;; cj/system-cmd
(ert-deftest test-system-cmd-string-runs-shell-process ()
"Normal: a plain string is wrapped in nohup and handed to
`start-process-shell-command'."
(let (cmd-line)
(cl-letf (((symbol-function 'start-process-shell-command)
(lambda (_name _buf c) (setq cmd-line c) 'fake-proc))
((symbol-function 'set-process-query-on-exit-flag) #'ignore)
((symbol-function 'set-process-sentinel) #'ignore)
((symbol-function 'message) #'ignore))
(cj/system-cmd "echo hi"))
(should (string-match-p "^nohup echo hi" cmd-line))
(should (string-match-p "&$" cmd-line))))
(ert-deftest test-system-cmd-confirm-decline-aborts ()
"Boundary: a confirm-tagged var with N response signals user-error."
(defvar test-sc-confirm-cmd "test-confirm-cmd")
(put 'test-sc-confirm-cmd 'cj/system-confirm t)
(unwind-protect
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?n))
((symbol-function 'start-process-shell-command)
(lambda (&rest _) (error "shouldn't run"))))
(should-error (cj/system-cmd 'test-sc-confirm-cmd) :type 'user-error))
(put 'test-sc-confirm-cmd 'cj/system-confirm nil)))
;;; cj/system-cmd-exit-emacs
(ert-deftest test-system-cmd-exit-emacs-decline-aborts ()
"Boundary: declining the prompt signals user-error; kill-emacs is not called."
(let ((killed nil))
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?n))
((symbol-function 'kill-emacs)
(lambda (&rest _) (setq killed t))))
(should-error (cj/system-cmd-exit-emacs) :type 'user-error))
(should-not killed)))
(ert-deftest test-system-cmd-exit-emacs-accept-calls-kill-emacs ()
"Normal: accepting the prompt calls `kill-emacs'."
(let ((killed nil))
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?y))
((symbol-function 'kill-emacs)
(lambda (&rest _) (setq killed t))))
(cj/system-cmd-exit-emacs))
(should killed)))
;;; cj/system-cmd-restart-emacs
(ert-deftest test-system-cmd-restart-emacs-decline-aborts ()
"Boundary: declining the prompt signals user-error before scheduling."
(let ((scheduled nil))
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?n))
((symbol-function 'save-some-buffers) #'ignore)
((symbol-function 'run-at-time)
(lambda (&rest _) (setq scheduled t))))
(should-error (cj/system-cmd-restart-emacs) :type 'user-error))
(should-not scheduled)))
(ert-deftest test-system-cmd-restart-emacs-accept-schedules-restart ()
"Normal: accepting the prompt schedules the restart + kill timers."
(let ((schedules 0))
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?y))
((symbol-function 'save-some-buffers) #'ignore)
((symbol-function 'run-at-time)
(lambda (&rest _) (cl-incf schedules)))
((symbol-function 'message) #'ignore))
(cj/system-cmd-restart-emacs))
(should (= schedules 2))))
(ert-deftest test-system-cmd-restart-emacs-restart-lambda-shells-out ()
"Normal: the lambda scheduled by the first `run-at-time' call invokes
`call-process-shell-command' with the systemctl restart line.
Captures the lambda passed to the first scheduling call and invokes it
directly with all relevant side effects stubbed, so the inner body
registers under coverage even though the real timer never fires."
(let (captured-lambda call-args)
(cl-letf (((symbol-function 'read-char-choice) (lambda (&rest _) ?y))
((symbol-function 'save-some-buffers) #'ignore)
((symbol-function 'run-at-time)
(lambda (_when _repeat fn)
(unless captured-lambda (setq captured-lambda fn))))
((symbol-function 'message) #'ignore)
((symbol-function 'call-process-shell-command)
(lambda (&rest args) (setq call-args args))))
(cj/system-cmd-restart-emacs)
(should (functionp captured-lambda))
(funcall captured-lambda)
(should call-args)
(should (string-match-p "systemctl --user restart emacs.service"
(car call-args))))))
;;; cj/system-command-menu
(ert-deftest test-system-command-menu-dispatches-by-name ()
"Normal: the completing-read selection routes through `call-interactively'."
(let ((called nil))
(cl-letf (((symbol-function 'completing-read)
(lambda (&rest _) "Lock Screen"))
((symbol-function 'call-interactively)
(lambda (cmd) (setq called cmd))))
(cj/system-command-menu))
(should (eq called 'cj/system-cmd-lock))))
(provide 'test-system-commands-resolve-and-run)
;;; test-system-commands-resolve-and-run.el ends here
|
