1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
;;; test-system-lib-auth-source-secret-value.el --- Tests for the auth-source secret primitive -*- lexical-binding: t; -*-
;;; Commentary:
;; `cj/auth-source-secret-value' is the shared low-level accessor that the
;; calendar-sync, ai-config, transcription, and slack helpers all delegate to.
;; It searches authinfo for HOST (and optional USER), resolves a
;; function-valued secret by calling it, and returns the value or nil. These
;; tests stub `auth-source-search' (the external boundary) and capture its args.
;;; Code:
(require 'ert)
(require 'cl-lib)
(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
(require 'system-lib)
(defvar test-ass--args nil "Captured args of the stubbed `auth-source-search'.")
(defmacro test-ass--with-search (return-value &rest body)
"Run BODY with `auth-source-search' stubbed to return RETURN-VALUE.
Captures the call args in `test-ass--args'."
(declare (indent 1))
`(let ((test-ass--args nil))
(cl-letf (((symbol-function 'auth-source-search)
(lambda (&rest args) (setq test-ass--args args) ,return-value)))
,@body)))
;;; Normal
(ert-deftest test-auth-source-secret-value-returns-string-secret ()
"Normal: a string :secret is returned as-is."
(test-ass--with-search (list (list :secret "sk-abc"))
(should (equal "sk-abc" (cj/auth-source-secret-value "api.example.com")))))
(ert-deftest test-auth-source-secret-value-calls-function-secret ()
"Normal: a function :secret is funcalled (the netrc backend returns one)."
(test-ass--with-search (list (list :secret (lambda () "from-fn")))
(should (equal "from-fn" (cj/auth-source-secret-value "api.example.com")))))
(ert-deftest test-auth-source-secret-value-passes-user-when-given ()
"Normal: USER and HOST are forwarded to `auth-source-search'."
(test-ass--with-search (list (list :secret "x"))
(cj/auth-source-secret-value "h" "apikey")
(should (equal "h" (plist-get test-ass--args :host)))
(should (equal "apikey" (plist-get test-ass--args :user)))))
;;; Boundary
(ert-deftest test-auth-source-secret-value-omits-user-when-absent ()
"Boundary: with no USER, :user is not added to the search spec."
(test-ass--with-search (list (list :secret "x"))
(cj/auth-source-secret-value "h")
(should-not (plist-member test-ass--args :user))))
(ert-deftest test-auth-source-secret-value-nil-on-no-match ()
"Boundary: no matching entry yields nil."
(test-ass--with-search nil
(should (null (cj/auth-source-secret-value "h")))))
(ert-deftest test-auth-source-secret-value-nil-on-entry-without-secret ()
"Boundary: a matching entry with no :secret yields nil."
(test-ass--with-search (list (list :host "h"))
(should (null (cj/auth-source-secret-value "h")))))
;;; Error
(ert-deftest test-auth-source-secret-value-loads-auth-source-when-absent ()
"Error: with `auth-source-search' unavailable, the helper loads auth-source.
Under `emacs --batch -Q' nothing else pulls auth-source in, so a helper
carrying only a `declare-function' dies with a void-function on the first
lookup. An interactive Emacs hides this completely -- something in init
always has auth-source loaded by the time anyone calls here -- which is why
it surfaced only on the batch calendar sync, and only on the machine whose
feeds resolve through `:secret-host' rather than an inline URL.
The stubbed `require' installs the entry point the way loading auth-source.el
would, so the call can complete and the return value is checked too."
(let ((required nil))
(cl-letf (((symbol-function 'auth-source-search) nil)
((symbol-function 'require)
(lambda (feature &rest _)
(push feature required)
(fset 'auth-source-search
(lambda (&rest _) (list (list :secret "loaded"))))
feature)))
(should (equal "loaded" (cj/auth-source-secret-value "h")))
(should (memq 'auth-source required)))))
(ert-deftest test-auth-source-secret-value-does-not-reload-when-present ()
"Error: an available `auth-source-search' is used as-is, never re-required.
An unconditional `require' re-loads auth-source.el over whatever is in place,
replacing a caller's stub mid-call -- which sent a test that meant to fake the
lookup out to the real authinfo, where it hung for twelve seconds on gpg."
(let ((required nil))
(cl-letf (((symbol-function 'require)
(lambda (feature &rest _) (push feature required) feature))
((symbol-function 'auth-source-search)
(lambda (&rest _) (list (list :secret "stubbed")))))
(should (equal "stubbed" (cj/auth-source-secret-value "h")))
(should-not (memq 'auth-source required)))))
(provide 'test-system-lib-auth-source-secret-value)
;;; test-system-lib-auth-source-secret-value.el ends here
|
