1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
;;; test-transcription-process-and-sentinel.el --- Tests for transcription start/notify/sentinel -*- lexical-binding: t; -*-
;;; Commentary:
;; Sibling files cover sentinel helpers (write-transcript, append-to-log,
;; update-status, notify-completion) and start helpers (init-log-file,
;; track-transcription). This file covers the three remaining bodies:
;;
;; cj/--notify
;; cj/--start-transcription-process
;; cj/--transcription-sentinel
;;; Code:
(require 'ert)
(require 'cl-lib)
(add-to-list 'load-path (expand-file-name "modules" user-emacs-directory))
(require 'transcription-config)
(defvar cj/transcriptions-list nil)
;;; cj/--notify
(ert-deftest test-tx-notify-always-messages ()
"Normal: notify echoes through `message' even without DISPLAY."
(let (msg)
(cl-letf (((symbol-function 'message)
(lambda (fmt &rest args) (setq msg (apply #'format fmt args))))
((symbol-function 'getenv) (lambda (_ &rest _) nil)))
(cj/--notify "Transcription" "started"))
(should (equal msg "Transcription: started"))))
(ert-deftest test-tx-notify-sends-desktop-when-display-set ()
"Normal: with DISPLAY set, notify calls `notifications-notify' with
the title, body, and urgency."
(let (notify-kwargs)
(cl-letf (((symbol-function 'message) #'ignore)
((symbol-function 'getenv)
(lambda (var &rest _) (and (equal var "DISPLAY") ":0")))
((symbol-function 'notifications-notify)
(lambda (&rest kwargs) (setq notify-kwargs kwargs))))
(cj/--notify "Transcription" "done" 'critical))
(should (equal (plist-get notify-kwargs :title) "Transcription"))
(should (equal (plist-get notify-kwargs :body) "done"))
(should (eq (plist-get notify-kwargs :urgency) 'critical))))
;;; cj/--start-transcription-process
(ert-deftest test-tx-start-process-errors-when-audio-missing ()
"Error: missing audio file signals user-error."
(should-error (cj/--start-transcription-process "/no/such/file.mp3")
:type 'user-error))
(ert-deftest test-tx-start-process-errors-when-not-audio ()
"Error: a real file with a non-audio extension signals user-error."
(let ((notes (make-temp-file "cj-tx-notes-" nil ".txt")))
(unwind-protect
(should-error (cj/--start-transcription-process notes)
:type 'user-error)
(delete-file notes))))
(ert-deftest test-tx-start-process-errors-when-script-not-executable ()
"Error: a non-executable script path signals user-error."
(let ((audio (make-temp-file "cj-tx-audio-" nil ".mp3")))
(unwind-protect
(cl-letf (((symbol-function 'cj/--transcription-script-path)
(lambda () "/no/such/script.sh")))
(should-error (cj/--start-transcription-process audio)
:type 'user-error))
(delete-file audio))))
(ert-deftest test-tx-start-process-spawns-make-process ()
"Normal: with audio + executable script, make-process is invoked with
the script and the audio path."
(let* ((audio (make-temp-file "cj-tx-audio-" nil ".mp3"))
(script (make-temp-file "cj-tx-script-"))
(cj/transcriptions-list nil)
make-process-args)
(set-file-modes script #o755)
(unwind-protect
(cl-letf (((symbol-function 'cj/--transcription-script-path)
(lambda () script))
((symbol-function 'cj/--init-log-file) #'ignore)
((symbol-function 'cj/--build-process-environment)
(lambda (_) '("FOO=bar")))
((symbol-function 'make-process)
(lambda (&rest kwargs)
(setq make-process-args kwargs)
'fake-process))
((symbol-function 'cj/--notify) #'ignore)
((symbol-function 'force-mode-line-update) #'ignore))
(cj/--start-transcription-process audio))
(delete-file audio)
(delete-file script))
(should make-process-args)
(should (equal (plist-get make-process-args :command)
(list script audio)))))
(ert-deftest test-tx-start-process-stderr-is-a-buffer-not-a-path ()
"Normal: :stderr is a live buffer, not a file path.
Passing a path string makes Emacs create a phantom buffer named after the
path, so stderr never reaches the log file and that buffer leaks per run."
(let* ((audio (make-temp-file "cj-tx-audio-" nil ".mp3"))
(script (make-temp-file "cj-tx-script-"))
(cj/transcriptions-list nil)
make-process-args)
(set-file-modes script #o755)
(unwind-protect
(cl-letf (((symbol-function 'cj/--transcription-script-path)
(lambda () script))
((symbol-function 'cj/--init-log-file) #'ignore)
((symbol-function 'cj/--build-process-environment)
(lambda (_) '("FOO=bar")))
((symbol-function 'make-process)
(lambda (&rest kwargs)
(setq make-process-args kwargs)
'fake-process))
((symbol-function 'cj/--notify) #'ignore)
((symbol-function 'force-mode-line-update) #'ignore))
(cj/--start-transcription-process audio))
(delete-file audio)
(delete-file script))
(let ((stderr (plist-get make-process-args :stderr)))
(should (bufferp stderr))
(should (buffer-live-p stderr))
(when (buffer-live-p stderr) (kill-buffer stderr)))))
;;; cj/--transcription-sentinel
(ert-deftest test-tx-sentinel-success-writes-transcript-and-updates-status ()
"Normal: a finished event with exit 0 writes the transcript, updates
the entry status to `complete', and fires a normal-urgency notification."
(let* ((txt-file (make-temp-file "cj-tx-txt-" nil ".txt"))
(log-file (make-temp-file "cj-tx-log-" nil ".log"))
(process-buffer (generate-new-buffer " *cj-tx-test*"))
(proc (list 'mock-process))
(stderr-buffer (generate-new-buffer " *cj-tx-test-stderr*"))
(cj/transcriptions-list (list (list proc "/tmp/audio.mp3"
(current-time) 'running)))
notify-urgency)
(with-current-buffer process-buffer (insert "transcript contents"))
(unwind-protect
(cl-letf (((symbol-function 'process-buffer)
(lambda (_) process-buffer))
((symbol-function 'process-exit-status) (lambda (_) 0))
((symbol-function 'cj/--should-keep-log)
(lambda (_) t))
((symbol-function 'run-at-time) #'ignore)
((symbol-function 'force-mode-line-update) #'ignore)
((symbol-function 'cj/--notify)
(lambda (_t _m &optional u) (setq notify-urgency u))))
(cj/--transcription-sentinel proc "finished\n"
"/tmp/audio.mp3"
txt-file log-file stderr-buffer))
(when (buffer-live-p process-buffer) (kill-buffer process-buffer))
(when (buffer-live-p stderr-buffer) (kill-buffer stderr-buffer))
(delete-file txt-file)
(delete-file log-file))
;; success notification uses default (nil/normal) urgency.
(should-not notify-urgency)
;; the stderr buffer is drained and killed, never leaked.
(should-not (buffer-live-p stderr-buffer))
;; entry status updated to complete.
(let ((entry (car cj/transcriptions-list)))
(should (eq (nth 3 entry) 'complete)))))
(ert-deftest test-tx-sentinel-failure-marks-error-and-uses-critical-urgency ()
"Normal: a non-zero exit fires the critical-urgency notification and
marks the entry as `error'."
(let* ((txt-file (make-temp-file "cj-tx-txt-" nil ".txt"))
(log-file (make-temp-file "cj-tx-log-" nil ".log"))
(process-buffer (generate-new-buffer " *cj-tx-fail*"))
(proc (list 'mock-fail))
(stderr-buffer (generate-new-buffer " *cj-tx-fail-stderr*"))
(cj/transcriptions-list (list (list proc "/tmp/audio.mp3"
(current-time) 'running)))
log-contents
notify-urgency)
(with-current-buffer process-buffer (insert "partial transcript"))
(with-current-buffer stderr-buffer (insert "whisper: CUDA out of memory"))
(with-temp-file log-file (insert "HEADER\n"))
(unwind-protect
(cl-letf (((symbol-function 'process-buffer)
(lambda (_) process-buffer))
((symbol-function 'process-exit-status) (lambda (_) 1))
((symbol-function 'cj/--should-keep-log) (lambda (_) t))
((symbol-function 'run-at-time) #'ignore)
((symbol-function 'force-mode-line-update) #'ignore)
((symbol-function 'cj/--notify)
(lambda (_t _m &optional u) (setq notify-urgency u))))
(cj/--transcription-sentinel proc "exited abnormally\n"
"/tmp/audio.mp3"
txt-file log-file stderr-buffer)
(setq log-contents
(with-temp-buffer (insert-file-contents log-file) (buffer-string))))
(when (buffer-live-p process-buffer) (kill-buffer process-buffer))
(when (buffer-live-p stderr-buffer) (kill-buffer stderr-buffer))
(delete-file txt-file)
(delete-file log-file))
(should (eq notify-urgency 'critical))
;; the actual stderr error text reaches the log on failure.
(should (string-match-p "CUDA out of memory" log-contents))
;; the stderr buffer is killed, never leaked.
(should-not (buffer-live-p stderr-buffer))
(let ((entry (car cj/transcriptions-list)))
(should (eq (nth 3 entry) 'error)))))
(provide 'test-transcription-process-and-sentinel)
;;; test-transcription-process-and-sentinel.el ends here
|
