diff options
| author | Craig Jennings <c@cjennings.net> | 2026-04-26 18:01:30 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-04-26 18:01:30 -0500 |
| commit | c5e5e1dfb808efa8724a993771e5258e728f83d1 (patch) | |
| tree | cd870fce078071d366920c19e7529b7dce8e18c0 /scripts/coverage-summary.py | |
| parent | 8f3c770e062a9aefec17f6b5f4f0a5ed927ac603 (diff) | |
| download | emacs-wttrin-c5e5e1dfb808efa8724a993771e5258e728f83d1.tar.gz emacs-wttrin-c5e5e1dfb808efa8724a993771e5258e728f83d1.zip | |
fix: omit :foreground from emoji icon face when no color provided
The font branch of wttrin--make-emoji-icon built its face plist with `:foreground foreground` even when foreground was nil, producing a literal `(:family ... :height 1.0 :foreground nil)`. The mode-line redisplays many times per second, and Emacs validates faces on every redisplay. A single fresh-cache state produced hundreds of "Invalid face attribute :foreground nil" warnings in *Messages*. The bug's been live since 2026-02-21 (b74b98f). The 130bbc07 helper extraction kept it in place.
Switch to backquote splicing so the :foreground key is included only when foreground is non-nil. Behavior is identical on the colored path. On the nil path the emoji renders with the default mode-line color, the same visible result as before, without the warning flood.
Diffstat (limited to 'scripts/coverage-summary.py')
0 files changed, 0 insertions, 0 deletions
