refactor: tests: standardize naming, consolidate files, and expand testutil

- Expand testutil-wttrin.el with shared fixtures and macros
  (testutil-wttrin-with-clean-weather-buffer,
  testutil-wttrin-mock-http-response, sample ANSI/weather constants)
- Consolidate cache tests: port unique tests from cleanup-cache-constants
  and cleanup-cache-refactored into cleanup-cache-if-needed, delete
  obsolete files
- Extract startup-delay tests into dedicated file
- Add setup/teardown and (require 'testutil-wttrin) to all test files
- Rename all 160 tests to follow
  test-<module>-<category>-<scenario>-<expected-result> convention
- Rename integration test file and add detailed docstrings
- Update Makefile glob to discover new integration test naming pattern

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

1 files changed, 126 insertions, 92 deletions

diff --git a/tests/test-wttrin--get-cache-entries-by-age.el b/tests/test-wttrin--get-cache-entries-by-age.el
index c840ac2..e847f88 100644
--- a/tests/test-wttrin--get-cache-entries-by-age.el
+++ b/tests/test-wttrin--get-cache-entries-by-age.el
@@ -10,116 +10,150 @@
 
 (require 'ert)
 (require 'wttrin)
+(require 'testutil-wttrin)
+
+;;; Setup and Teardown
+
+(defun test-wttrin--get-cache-entries-by-age-setup ()
+  "Setup for get-cache-entries-by-age tests."
+  (testutil-wttrin-setup))
+
+(defun test-wttrin--get-cache-entries-by-age-teardown ()
+  "Teardown for get-cache-entries-by-age tests."
+  (testutil-wttrin-teardown))
 
 ;;; Normal Cases
 
-(ert-deftest test-wttrin--get-cache-entries-by-age-empty-cache ()
+(ert-deftest test-wttrin--get-cache-entries-by-age-normal-empty-cache-returns-empty-list ()
   "Should return empty list when cache is empty."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    (should (equal '() (wttrin--get-cache-entries-by-age)))))
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (should (equal '() (wttrin--get-cache-entries-by-age)))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
 
-(ert-deftest test-wttrin--get-cache-entries-by-age-single-entry ()
+(ert-deftest test-wttrin--get-cache-entries-by-age-normal-single-entry-returns-one-element ()
   "Should return single entry in list."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    (puthash "Paris|m" (cons 1000.0 "weather data") wttrin--cache)
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      (should (= 1 (length result)))
-      (should (equal "Paris|m" (car (car result))))
-      (should (= 1000.0 (cdr (car result)))))))
-
-(ert-deftest test-wttrin--get-cache-entries-by-age-sorted-oldest-first ()
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        (puthash "Paris|m" (cons 1000.0 "weather data") wttrin--cache)
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          (should (= 1 (length result)))
+          (should (equal "Paris|m" (car (car result))))
+          (should (= 1000.0 (cdr (car result))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
+
+(ert-deftest test-wttrin--get-cache-entries-by-age-normal-multiple-entries-returns-sorted-oldest-first ()
   "Should return entries sorted by timestamp, oldest first."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    ;; Add entries with different timestamps (not in sorted order)
-    (puthash "New York|u" (cons 3000.0 "newest data") wttrin--cache)
-    (puthash "Paris|m" (cons 1000.0 "oldest data") wttrin--cache)
-    (puthash "Tokyo|m" (cons 2000.0 "middle data") wttrin--cache)
-
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      (should (= 3 (length result)))
-      ;; Check order: oldest to newest
-      (should (equal "Paris|m" (car (nth 0 result))))
-      (should (= 1000.0 (cdr (nth 0 result))))
-      (should (equal "Tokyo|m" (car (nth 1 result))))
-      (should (= 2000.0 (cdr (nth 1 result))))
-      (should (equal "New York|u" (car (nth 2 result))))
-      (should (= 3000.0 (cdr (nth 2 result)))))))
-
-(ert-deftest test-wttrin--get-cache-entries-by-age-returns-key-timestamp-pairs ()
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        ;; Add entries with different timestamps (not in sorted order)
+        (puthash "New York|u" (cons 3000.0 "newest data") wttrin--cache)
+        (puthash "Paris|m" (cons 1000.0 "oldest data") wttrin--cache)
+        (puthash "Tokyo|m" (cons 2000.0 "middle data") wttrin--cache)
+
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          (should (= 3 (length result)))
+          ;; Check order: oldest to newest
+          (should (equal "Paris|m" (car (nth 0 result))))
+          (should (= 1000.0 (cdr (nth 0 result))))
+          (should (equal "Tokyo|m" (car (nth 1 result))))
+          (should (= 2000.0 (cdr (nth 1 result))))
+          (should (equal "New York|u" (car (nth 2 result))))
+          (should (= 3000.0 (cdr (nth 2 result))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
+
+(ert-deftest test-wttrin--get-cache-entries-by-age-normal-entry-format-returns-key-timestamp-pairs ()
   "Should return (key . timestamp) pairs, not full cache values."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    ;; Cache value is (timestamp . data)
-    (puthash "London|m" (cons 1500.0 "complete weather string with lots of data") wttrin--cache)
-
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      (should (= 1 (length result)))
-      (let ((entry (car result)))
-        ;; Entry should be (key . timestamp), not (key . (timestamp . data))
-        (should (equal "London|m" (car entry)))
-        (should (= 1500.0 (cdr entry)))
-        ;; Should NOT contain the weather data string
-        (should-not (stringp (cdr entry)))))))
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        ;; Cache value is (timestamp . data)
+        (puthash "London|m" (cons 1500.0 "complete weather string with lots of data") wttrin--cache)
+
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          (should (= 1 (length result)))
+          (let ((entry (car result)))
+            ;; Entry should be (key . timestamp), not (key . (timestamp . data))
+            (should (equal "London|m" (car entry)))
+            (should (= 1500.0 (cdr entry)))
+            ;; Should NOT contain the weather data string
+            (should-not (stringp (cdr entry))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
 
 ;;; Boundary Cases
 
-(ert-deftest test-wttrin--get-cache-entries-by-age-same-timestamp ()
+(ert-deftest test-wttrin--get-cache-entries-by-age-boundary-same-timestamp-returns-all-entries ()
   "Should handle entries with identical timestamps."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    (puthash "Location1|m" (cons 1000.0 "data1") wttrin--cache)
-    (puthash "Location2|m" (cons 1000.0 "data2") wttrin--cache)
-    (puthash "Location3|m" (cons 1000.0 "data3") wttrin--cache)
-
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      (should (= 3 (length result)))
-      ;; All should have same timestamp
-      (should (= 1000.0 (cdr (nth 0 result))))
-      (should (= 1000.0 (cdr (nth 1 result))))
-      (should (= 1000.0 (cdr (nth 2 result)))))))
-
-(ert-deftest test-wttrin--get-cache-entries-by-age-float-timestamps ()
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        (puthash "Location1|m" (cons 1000.0 "data1") wttrin--cache)
+        (puthash "Location2|m" (cons 1000.0 "data2") wttrin--cache)
+        (puthash "Location3|m" (cons 1000.0 "data3") wttrin--cache)
+
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          (should (= 3 (length result)))
+          ;; All should have same timestamp
+          (should (= 1000.0 (cdr (nth 0 result))))
+          (should (= 1000.0 (cdr (nth 1 result))))
+          (should (= 1000.0 (cdr (nth 2 result))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
+
+(ert-deftest test-wttrin--get-cache-entries-by-age-boundary-float-timestamps-sorts-correctly ()
   "Should correctly sort float timestamps with fractional seconds."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    (puthash "A|m" (cons 1000.123 "data") wttrin--cache)
-    (puthash "B|m" (cons 1000.789 "data") wttrin--cache)
-    (puthash "C|m" (cons 1000.456 "data") wttrin--cache)
-
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      ;; Should be sorted: 1000.123 < 1000.456 < 1000.789
-      (should (equal "A|m" (car (nth 0 result))))
-      (should (equal "C|m" (car (nth 1 result))))
-      (should (equal "B|m" (car (nth 2 result)))))))
-
-(ert-deftest test-wttrin--get-cache-entries-by-age-many-entries ()
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        (puthash "A|m" (cons 1000.123 "data") wttrin--cache)
+        (puthash "B|m" (cons 1000.789 "data") wttrin--cache)
+        (puthash "C|m" (cons 1000.456 "data") wttrin--cache)
+
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          ;; Should be sorted: 1000.123 < 1000.456 < 1000.789
+          (should (equal "A|m" (car (nth 0 result))))
+          (should (equal "C|m" (car (nth 1 result))))
+          (should (equal "B|m" (car (nth 2 result))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
+
+(ert-deftest test-wttrin--get-cache-entries-by-age-boundary-fifty-entries-returns-sorted ()
   "Should handle cache at max capacity (50 entries)."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    ;; Add 50 entries with timestamps 1000, 1001, 1002, ..., 1049
-    (dotimes (i 50)
-      (puthash (format "Location%d|m" i)
-               (cons (+ 1000.0 i) "data")
-               wttrin--cache))
-
-    (let ((result (wttrin--get-cache-entries-by-age)))
-      (should (= 50 (length result)))
-      ;; First should be oldest (1000.0)
-      (should (= 1000.0 (cdr (car result))))
-      ;; Last should be newest (1049.0)
-      (should (= 1049.0 (cdr (car (last result))))))))
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        ;; Add 50 entries with timestamps 1000, 1001, 1002, ..., 1049
+        (dotimes (i 50)
+          (puthash (format "Location%d|m" i)
+                   (cons (+ 1000.0 i) "data")
+                   wttrin--cache))
+
+        (let ((result (wttrin--get-cache-entries-by-age)))
+          (should (= 50 (length result)))
+          ;; First should be oldest (1000.0)
+          (should (= 1000.0 (cdr (car result))))
+          ;; Last should be newest (1049.0)
+          (should (= 1049.0 (cdr (car (last result)))))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
 
 ;;; Error Cases
 
-(ert-deftest test-wttrin--get-cache-entries-by-age-preserves-original-cache ()
+(ert-deftest test-wttrin--get-cache-entries-by-age-error-call-preserves-original-cache ()
   "Should not modify the original cache hash table."
-  (let ((wttrin--cache (make-hash-table :test 'equal)))
-    (puthash "Paris|m" (cons 1000.0 "data") wttrin--cache)
-    (puthash "Tokyo|m" (cons 2000.0 "data") wttrin--cache)
-
-    (let ((original-count (hash-table-count wttrin--cache)))
-      (wttrin--get-cache-entries-by-age)
-      ;; Cache should still have same number of entries
-      (should (= original-count (hash-table-count wttrin--cache)))
-      ;; Original entries should still be present
-      (should (gethash "Paris|m" wttrin--cache))
-      (should (gethash "Tokyo|m" wttrin--cache)))))
+  (test-wttrin--get-cache-entries-by-age-setup)
+  (unwind-protect
+      (progn
+        (puthash "Paris|m" (cons 1000.0 "data") wttrin--cache)
+        (puthash "Tokyo|m" (cons 2000.0 "data") wttrin--cache)
+
+        (let ((original-count (hash-table-count wttrin--cache)))
+          (wttrin--get-cache-entries-by-age)
+          ;; Cache should still have same number of entries
+          (should (= original-count (hash-table-count wttrin--cache)))
+          ;; Original entries should still be present
+          (should (gethash "Paris|m" wttrin--cache))
+          (should (gethash "Tokyo|m" wttrin--cache))))
+    (test-wttrin--get-cache-entries-by-age-teardown)))
 
 (provide 'test-wttrin--get-cache-entries-by-age)
 ;;; test-wttrin--get-cache-entries-by-age.el ends here