1 files changed, 52 insertions, 0 deletions
diff --git a/tests/test-wttrin-set-location-from-geolocation.el b/tests/test-wttrin-set-location-from-geolocation.el
index 170d0fb..f16b2ae 100644
--- a/tests/test-wttrin-set-location-from-geolocation.el
+++ b/tests/test-wttrin-set-location-from-geolocation.el
@@ -65,6 +65,29 @@
         (should (string= "Pre-existing, Place" wttrin-favorite-location)))
     (test-wttrin-set-location-from-geolocation-teardown)))
 
+(ert-deftest test-wttrin-set-location-from-geolocation-normal-confirm-refreshes-mode-line ()
+  "Normal: a confirmed detection refreshes the mode-line so it tracks the new
+favorite immediately instead of at the next scheduled fetch."
+  (test-wttrin-set-location-from-geolocation-setup)
+  (setq wttrin-favorite-location "Pre-existing, Place")
+  (unwind-protect
+      (let ((wttrin-geolocation-enabled t)
+            (wttrin-mode-line-mode t)
+            (wttrin--location-history nil)
+            (fetched nil))
+        (cl-letf (((symbol-function 'wttrin-geolocation-detect)
+                   (lambda (callback) (funcall callback "Berkeley, California")))
+                  ((symbol-function 'yes-or-no-p) (lambda (&rest _) t))
+                  ((symbol-function 'message) (lambda (&rest _) nil))
+                  ((symbol-function 'wttrin--mode-line-fetch-weather)
+                   (lambda () (setq fetched t)))
+                  ((symbol-function 'wttrin--mode-line-set-placeholder)
+                   (lambda () nil)))
+          (wttrin-set-location-from-geolocation))
+        (should (string= "Berkeley, California" wttrin-favorite-location))
+        (should fetched))
+    (test-wttrin-set-location-from-geolocation-teardown)))
+
 ;;; Boundary Cases
 
 (ert-deftest test-wttrin-set-location-from-geolocation-boundary-unicode-location ()
@@ -118,5 +141,34 @@
                          messages)))
     (test-wttrin-set-location-from-geolocation-teardown)))
 
+;;; Opt-out
+
+(ert-deftest test-wttrin-set-location-from-geolocation-boundary-disabled-no-detect ()
+  "Boundary: with geolocation disabled, the command neither detects nor sets."
+  (test-wttrin-set-location-from-geolocation-setup)
+  (setq wttrin-favorite-location "Pre-existing, Place")
+  (unwind-protect
+      (let ((detected nil)
+            (wttrin-geolocation-enabled nil))
+        (cl-letf (((symbol-function 'wttrin-geolocation-detect)
+                   (lambda (_cb) (setq detected t)))
+                  ((symbol-function 'message) (lambda (&rest _) nil)))
+          (wttrin-set-location-from-geolocation))
+        (should-not detected)
+        (should (string= "Pre-existing, Place" wttrin-favorite-location)))
+    (test-wttrin-set-location-from-geolocation-teardown)))
+
+;;; Deprecation
+
+(ert-deftest test-wttrin-set-location-from-geolocation-normal-marked-obsolete ()
+  "Normal: the command is marked obsolete with a steering message.
+The favorite-setting behavior is preserved (see the Normal cases above);
+this only asserts the obsolescence marker so callers get a deprecation
+notice steering them to the picker."
+  (let ((info (get 'wttrin-set-location-from-geolocation 'byte-obsolete-info)))
+    (should info)
+    ;; Option 1: a steering string, not an alias to another function.
+    (should (stringp (nth 0 info)))))
+
 (provide 'test-wttrin-set-location-from-geolocation)
 ;;; test-wttrin-set-location-from-geolocation.el ends here