diff options
| author | Craig Jennings <c@cjennings.net> | 2026-04-28 18:16:28 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-04-28 19:09:22 -0500 |
| commit | 3491d9b799f9678f6095149a348330e2a05a1924 (patch) | |
| tree | 496069dd668ce30d036090486b2c30dd6f681872 /tests/test-gloss-fetch--multi-source-walks-registry.el | |
| parent | dc0db0f0e12d8af6d1d54a5dde1cd16cf890a33d (diff) | |
| download | gloss-3491d9b799f9678f6095149a348330e2a05a1924.tar.gz gloss-3491d9b799f9678f6095149a348330e2a05a1924.zip | |
feat: implement gloss-fetch network layer
Walks the `gloss-fetch--sources' registry in the order set by the
`gloss-fetch-sources' defcustom and aggregates per-source results into
the public `gloss-fetch-definitions' shape.
The Wiktionary REST fetcher GETs the page-definition endpoint, parses
JSON, walks only English (`en') entries, and HTML-strips each sense via
`libxml-parse-html-region'. A sense whose strip fails is dropped while
the source keeps its `:ok' status with N-1 entries.
The HTTP-status taxonomy is five values: `:ok', `:no-defs' (404 or no
English senses on a 200), `:rate-limited' (429), `:server-error' (5xx,
malformed JSON, schema mismatch, 4xx other than 404 or 429), and
`:unreachable' (nil from `url-retrieve-synchronously', or a signaled
error). The `:reason' string carries technical detail to *gloss-debug*
and never reaches the user.
libxml is probed once per session at first fetch. When absent, online
fetch is disabled package-wide and every call signals `user-error' with
the install hint. `url-retrieve-synchronously' is wrapped with the
`gloss-fetch-timeout' defcustom (default 5 seconds).
Tested with `make test'. 60 of 62 tests pass. The two pending failures
load Wiktionary fixtures via `gloss-test--load-wiktionary-fixture',
which is provided on a parallel branch and will pass once both branches
land. The implementation has been verified against the captured
fixtures end-to-end (anaphora returns 4 senses, SBIR returns 2,
matching the design's expected counts).
Diffstat (limited to 'tests/test-gloss-fetch--multi-source-walks-registry.el')
| -rw-r--r-- | tests/test-gloss-fetch--multi-source-walks-registry.el | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/test-gloss-fetch--multi-source-walks-registry.el b/tests/test-gloss-fetch--multi-source-walks-registry.el index fe04e02..cb2b730 100644 --- a/tests/test-gloss-fetch--multi-source-walks-registry.el +++ b/tests/test-gloss-fetch--multi-source-walks-registry.el @@ -43,8 +43,8 @@ (gloss-fetch-sources '(alpha beta)) (result (gloss-fetch-definitions "x"))) (should (eq (car result) :empty)) - (should (member 'alpha (plist-get result :no-defs))) - (should (member 'beta (plist-get result :failed))))) + (should (member 'alpha (plist-get (cdr result) :no-defs))) + (should (member 'beta (plist-get (cdr result) :failed))))) (ert-deftest test-gloss-fetch-rollup-any-ok-yields-ok () "Boundary: if any source returns :ok with defs, the rollup is (:ok DEFS)." |