test: catch cl-assertion-failed by name without ERT should-wrapping

The previous fix wrapped condition-case in (should (eq 'caught ...)),
but ERT in Emacs 29.4 installs signal-hook-function around should
forms — that hook fires on every signal, intercepting them before
the inner condition-case can catch.  CI on 29.4 still failed.

This iteration drops should entirely.  Each test body becomes a
plain condition-case at the top level: run the form, and if it
returns normally, ert-fail.  Catch cl-assertion-failed by name
rather than via the error parent — its parent-class registration
is inconsistent across Emacs versions, but the symbol-name match
through condition-case always works.

Locally green; let's see what 29.4 does with it.

0 files changed, 0 insertions, 0 deletions