diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-26 18:09:21 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-26 18:09:21 -0500 |
| commit | 1338b2ae757b7143fe4d211fc5a354c73cee526b (patch) | |
| tree | d9b1afbc6b15754439314ad47cbcc053ad9d3598 /tests/test-org-drill-autoloads.el | |
| parent | 1a53381a176e99f5c7f9bed1589dbaf689f38390 (diff) | |
| download | org-drill-1338b2ae757b7143fe4d211fc5a354c73cee526b.tar.gz org-drill-1338b2ae757b7143fe4d211fc5a354c73cee526b.zip | |
chore: coverage, autoload fix, and internal cleanup for org-drill
A batch of test-coverage and hardening work, squashed from the test-work branch.
Tests: deduplicated a colliding leitner-capture test name so make test-name loads again. Added SM2 assert-failure cases, the six basic multicloze variant delegations, the three English-side spanish-verb branches, and org-drill-current-scope branch coverage.
Fix: the entry-point commands (org-drill itself, cram-tree, tree, directory, resume, relearn-item, strip-all-data, merge-buffers) carried no autoload cookies, so M-x failed from a fresh install until something pulled the file in. They're autoloaded now.
Perf: org-drill-shuffle was quadratic because it indexed a list with elt on every swap. It runs a linear Fisher-Yates pass over a vector now, and it checks its argument is a list.
Feat: added org-drill-version, a constant plus an interactive command, so a bug reporter doesn't have to open the file header.
Refactor: extracted org-drill--format-tense-mood, shared by the two verb-conjugation presenters that each carried a copy.
Docs: explained the SM8 magic numbers in the simple8 helpers as empirical fits rather than tunable knobs.
Diffstat (limited to 'tests/test-org-drill-autoloads.el')
| -rw-r--r-- | tests/test-org-drill-autoloads.el | 47 |
1 files changed, 47 insertions, 0 deletions
diff --git a/tests/test-org-drill-autoloads.el b/tests/test-org-drill-autoloads.el new file mode 100644 index 0000000..5bfefce --- /dev/null +++ b/tests/test-org-drill-autoloads.el @@ -0,0 +1,47 @@ +;;; test-org-drill-autoloads.el --- Autoload-cookie coverage -*- lexical-binding: t; -*- + +;;; Commentary: +;; The user-facing entry-point commands must carry an `;;;###autoload' cookie +;; so they work from a fresh package install before org-drill is loaded. +;; Without it, `M-x org-drill-resume' (etc.) fails with "command not found" +;; until something pulls the file in. +;; +;; This reads the source via `find-library-name' (the .el, not a compiled +;; .elc which would have the cookies stripped) and checks each command. + +;;; Code: + +(require 'ert) +(require 'org-drill) + +(defconst test-org-drill-autoloaded-commands + '("org-drill" + "org-drill-cram" + "org-drill-cram-tree" + "org-drill-tree" + "org-drill-directory" + "org-drill-again" + "org-drill-resume" + "org-drill-relearn-item" + "org-drill-strip-all-data" + "org-drill-merge-buffers") + "Entry-point commands that should be autoloaded.") + +(ert-deftest test-org-drill-entry-commands-carry-autoload-cookie () + "Each user-facing entry-point command is preceded by an autoload cookie." + (let ((src (with-temp-buffer + (insert-file-contents (find-library-name "org-drill")) + (buffer-string)))) + (dolist (cmd test-org-drill-autoloaded-commands) + (should (string-match-p + (concat ";;;###autoload\n(defun " (regexp-quote cmd) " ") + src))))) + +(ert-deftest test-org-drill-entry-commands-are-interactive () + "Every command in the autoload list is actually an interactive command." + (dolist (cmd test-org-drill-autoloaded-commands) + (should (commandp (intern cmd))))) + +(provide 'test-org-drill-autoloads) + +;;; test-org-drill-autoloads.el ends here |
