diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-26 18:09:21 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-26 18:09:21 -0500 |
| commit | 1338b2ae757b7143fe4d211fc5a354c73cee526b (patch) | |
| tree | d9b1afbc6b15754439314ad47cbcc053ad9d3598 /tests/test-org-drill-utilities-and-leitner.el | |
| parent | 1a53381a176e99f5c7f9bed1589dbaf689f38390 (diff) | |
| download | org-drill-1338b2ae757b7143fe4d211fc5a354c73cee526b.tar.gz org-drill-1338b2ae757b7143fe4d211fc5a354c73cee526b.zip | |
chore: coverage, autoload fix, and internal cleanup for org-drill
A batch of test-coverage and hardening work, squashed from the test-work branch.
Tests: deduplicated a colliding leitner-capture test name so make test-name loads again. Added SM2 assert-failure cases, the six basic multicloze variant delegations, the three English-side spanish-verb branches, and org-drill-current-scope branch coverage.
Fix: the entry-point commands (org-drill itself, cram-tree, tree, directory, resume, relearn-item, strip-all-data, merge-buffers) carried no autoload cookies, so M-x failed from a fresh install until something pulled the file in. They're autoloaded now.
Perf: org-drill-shuffle was quadratic because it indexed a list with elt on every swap. It runs a linear Fisher-Yates pass over a vector now, and it checks its argument is a list.
Feat: added org-drill-version, a constant plus an interactive command, so a bug reporter doesn't have to open the file header.
Refactor: extracted org-drill--format-tense-mood, shared by the two verb-conjugation presenters that each carried a copy.
Docs: explained the SM8 magic numbers in the simple8 helpers as empirical fits rather than tunable knobs.
Diffstat (limited to 'tests/test-org-drill-utilities-and-leitner.el')
| -rw-r--r-- | tests/test-org-drill-utilities-and-leitner.el | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/test-org-drill-utilities-and-leitner.el b/tests/test-org-drill-utilities-and-leitner.el index cc0157c..02761a2 100644 --- a/tests/test-org-drill-utilities-and-leitner.el +++ b/tests/test-org-drill-utilities-and-leitner.el @@ -61,6 +61,12 @@ (ert-deftest test-org-drill-shuffle-single-element-unchanged () (should (equal '(42) (org-drill-shuffle (list 42))))) +(ert-deftest test-org-drill-shuffle-rejects-non-list () + "The argument must be a list. A non-list (number, vector) is rejected +with a clear type error rather than silently coerced." + (should-error (org-drill-shuffle 42) :type 'wrong-type-argument) + (should-error (org-drill-shuffle [1 2 3]) :type 'wrong-type-argument)) + ;;;; org-drill-pop-random (macro) (ert-deftest test-org-drill-pop-random-removes-one-element () |