aboutsummaryrefslogtreecommitdiff
path: root/tests/test-pearl-adhoc.el
diff options
context:
space:
mode:
authorCraig Jennings <c@cjennings.net>2026-06-01 17:33:09 -0500
committerCraig Jennings <c@cjennings.net>2026-06-01 17:33:09 -0500
commitc2ba1d8f25463bf6342ac635850500a9738b31e9 (patch)
tree69518c846bc2e9b11559dc637b6ee81d9d3511c0 /tests/test-pearl-adhoc.el
parent4eab7a048ca18eeef31e4f8d0823182fc6e2368f (diff)
downloadpearl-c2ba1d8f25463bf6342ac635850500a9738b31e9.tar.gz
pearl-c2ba1d8f25463bf6342ac635850500a9738b31e9.zip
refactor: rename saved-query surface to local-view vocabulary
I renamed Pearl's "saved query" surface to the local/Linear view vocabulary, with no obsolete aliases, since Pearl has no users to protect. The defcustom pearl-saved-queries is now pearl-local-views. The commands pearl-run-saved-query, pearl-delete-saved-query, pearl-sync-saved-query-to-linear, pearl-run-view, and pearl-publish-current-source become pearl-run-local-view, pearl-delete-local-view, pearl-publish-local-view, pearl-run-linear-view, and pearl-publish-current-view. User-facing prompts, messages, and docstrings drop "saved query" for "local view", and the publish command reads "publish" instead of "sync". Internal GraphQL and helper names keep their "query" terms, which a user never sees. A naming-regression test asserts the new symbols exist, the old ones are gone rather than aliased, and no public command exposes "query". Phase 1 of docs/local-and-linear-views-spec.org. No behavior change. Suite, compile, and lint are green.
Diffstat (limited to 'tests/test-pearl-adhoc.el')
-rw-r--r--tests/test-pearl-adhoc.el54
1 files changed, 27 insertions, 27 deletions
diff --git a/tests/test-pearl-adhoc.el b/tests/test-pearl-adhoc.el
index 558578a..4959840 100644
--- a/tests/test-pearl-adhoc.el
+++ b/tests/test-pearl-adhoc.el
@@ -159,82 +159,82 @@ candidate list, so completion still works the way the framework expects."
(ert-deftest test-pearl-save-query-adds-entry ()
"Saving a query adds it to the saved-queries variable."
- (let ((pearl-saved-queries nil))
+ (let ((pearl-local-views nil))
(cl-letf (((symbol-function 'customize-save-variable) (lambda (&rest _) nil)))
(pearl--save-query "My filter" '(:open t :labels ("bug")))
- (let ((entry (assoc "My filter" pearl-saved-queries)))
+ (let ((entry (assoc "My filter" pearl-local-views)))
(should entry)
(should (equal '(:open t :labels ("bug")) (plist-get (cdr entry) :filter)))))))
(ert-deftest test-pearl-save-query-replaces-same-name ()
"Saving under an existing name replaces that entry rather than duplicating."
- (let ((pearl-saved-queries '(("Dup" :filter (:open t)))))
+ (let ((pearl-local-views '(("Dup" :filter (:open t)))))
(cl-letf (((symbol-function 'customize-save-variable) (lambda (&rest _) nil)))
(pearl--save-query "Dup" '(:priority 1))
- (should (= 1 (cl-count "Dup" pearl-saved-queries
+ (should (= 1 (cl-count "Dup" pearl-local-views
:key #'car :test #'string=)))
(should (equal '(:priority 1)
- (plist-get (cdr (assoc "Dup" pearl-saved-queries)) :filter))))))
+ (plist-get (cdr (assoc "Dup" pearl-local-views)) :filter))))))
-;;; pearl-delete-saved-query
+;;; pearl-delete-local-view
(ert-deftest test-pearl-delete-saved-query-removes-entry-on-yes ()
"Confirming the prompt removes the named entry and persists."
- (let ((pearl-saved-queries '(("Keep" :filter (:open t))
+ (let ((pearl-local-views '(("Keep" :filter (:open t))
("Drop" :filter (:priority 1))))
(persisted nil))
(cl-letf (((symbol-function 'yes-or-no-p) (lambda (&rest _) t))
((symbol-function 'customize-save-variable)
(lambda (&rest _) (setq persisted t))))
- (pearl-delete-saved-query "Drop")
- (should-not (assoc "Drop" pearl-saved-queries))
- (should (assoc "Keep" pearl-saved-queries))
+ (pearl-delete-local-view "Drop")
+ (should-not (assoc "Drop" pearl-local-views))
+ (should (assoc "Keep" pearl-local-views))
(should persisted))))
(ert-deftest test-pearl-delete-saved-query-no-at-confirm-keeps-entry ()
"Declining the confirm prompt leaves the entry in place and does not persist."
- (let ((pearl-saved-queries '(("Keep" :filter (:open t))))
+ (let ((pearl-local-views '(("Keep" :filter (:open t))))
(persisted nil))
(cl-letf (((symbol-function 'yes-or-no-p) (lambda (&rest _) nil))
((symbol-function 'customize-save-variable)
(lambda (&rest _) (setq persisted t))))
- (pearl-delete-saved-query "Keep")
- (should (assoc "Keep" pearl-saved-queries))
+ (pearl-delete-local-view "Keep")
+ (should (assoc "Keep" pearl-local-views))
(should-not persisted))))
(ert-deftest test-pearl-delete-saved-query-sentinel-cancels ()
"Picking the `pearl--filter-cancel' sentinel cancels without touching anything."
- (let ((pearl-saved-queries '(("Keep" :filter (:open t))))
+ (let ((pearl-local-views '(("Keep" :filter (:open t))))
(confirmed nil))
(cl-letf (((symbol-function 'yes-or-no-p)
(lambda (&rest _) (setq confirmed t) t))
((symbol-function 'customize-save-variable)
(lambda (&rest _) nil)))
- (pearl-delete-saved-query pearl--filter-cancel)
- (should (assoc "Keep" pearl-saved-queries))
+ (pearl-delete-local-view pearl--filter-cancel)
+ (should (assoc "Keep" pearl-local-views))
(should-not confirmed))))
(ert-deftest test-pearl-delete-saved-query-unknown-name-errors ()
"An unknown name (e.g. typed past completion) signals a user-error."
- (let ((pearl-saved-queries '(("Keep" :filter (:open t)))))
- (should-error (pearl-delete-saved-query "Nope") :type 'user-error)))
+ (let ((pearl-local-views '(("Keep" :filter (:open t)))))
+ (should-error (pearl-delete-local-view "Nope") :type 'user-error)))
(ert-deftest test-pearl-delete-saved-query-empty-list-errors-on-interactive ()
- "Called interactively with no saved queries, the command errors cleanly
+ "Called interactively with no local views, the command errors cleanly
rather than offering an empty picker."
- (let ((pearl-saved-queries nil))
- (should-error (call-interactively #'pearl-delete-saved-query)
+ (let ((pearl-local-views nil))
+ (should-error (call-interactively #'pearl-delete-local-view)
:type 'user-error)))
-;;; pearl-run-saved-query sentinel cancel
+;;; pearl-run-local-view sentinel cancel
(ert-deftest test-pearl-run-saved-query-sentinel-cancels ()
"Picking the `pearl--filter-cancel' sentinel cancels the run without fetching."
(let ((fetched nil)
- (pearl-saved-queries '(("Open" :filter (:open t)))))
+ (pearl-local-views '(("Open" :filter (:open t)))))
(cl-letf (((symbol-function 'pearl--query-issues-async)
(lambda (&rest _) (setq fetched t))))
- (should-error (pearl-run-saved-query pearl--filter-cancel) :type 'user-error)
+ (should-error (pearl-run-local-view pearl--filter-cancel) :type 'user-error)
(should-not fetched))))
;;; pearl-list-issues-filtered
@@ -255,8 +255,8 @@ rather than offering an empty picker."
(should (equal '(:assignee :me :open t) (plist-get rendered-source :filter))))))
(ert-deftest test-pearl-list-issues-filtered-saves-when-named ()
- "Passing a save name persists the ad-hoc filter as a saved query."
- (let ((pearl-saved-queries nil))
+ "Passing a save name persists the ad-hoc filter as a local view."
+ (let ((pearl-local-views nil))
(cl-letf (((symbol-function 'pearl--build-issue-filter) (lambda (_p) nil))
((symbol-function 'pearl--query-issues-async)
(lambda (_f cb &optional _o)
@@ -264,7 +264,7 @@ rather than offering an empty picker."
((symbol-function 'pearl--render-query-result) (lambda (&rest _) nil))
((symbol-function 'customize-save-variable) (lambda (&rest _) nil)))
(pearl-list-issues-filtered '(:open t) "Saved adhoc")
- (should (assoc "Saved adhoc" pearl-saved-queries)))))
+ (should (assoc "Saved adhoc" pearl-local-views)))))
(provide 'test-pearl-adhoc)
;;; test-pearl-adhoc.el ends here