diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-26 20:10:42 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-26 20:10:42 -0500 |
| commit | cfc42c41426d61f53c49b1f192751bcd061e57ae (patch) | |
| tree | 0091739c4f499c5a6a849f6241139479a23f14f0 /tests/test-pearl-delete.el | |
| parent | 34c67ddc3b72f92033ced3f86346f3483f5ba463 (diff) | |
| download | pearl-cfc42c41426d61f53c49b1f192751bcd061e57ae.tar.gz pearl-cfc42c41426d61f53c49b1f192751bcd061e57ae.zip | |
fix(commands): run add-comment and delete from anywhere in a ticket
pearl-add-comment and pearl-delete-current-issue guarded position with the nearest-heading check, so from inside a comment subtree, or any heading without a LINEAR-ID, they errored "Not on a Linear issue heading". Both docstrings already claimed they work from anywhere in the subtree, so the behavior was just wrong.
The edit and save commands already climb to the issue via pearl--goto-issue-heading-or-error. I switched these two to the same guard, so every ticket-scoped command resolves the enclosing issue from anywhere in its subtree, including from inside a comment. The redundant LINEAR-ID re-checks are gone since the guard guarantees it. Walk-up tests added for both.
Diffstat (limited to 'tests/test-pearl-delete.el')
| -rw-r--r-- | tests/test-pearl-delete.el | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tests/test-pearl-delete.el b/tests/test-pearl-delete.el index 02d3380..ea5027f 100644 --- a/tests/test-pearl-delete.el +++ b/tests/test-pearl-delete.el @@ -93,6 +93,20 @@ (cl-letf (((symbol-function 'yes-or-no-p) (lambda (&rest _) t))) (should-error (pearl-delete-current-issue) :type 'user-error)))) +(ert-deftest test-pearl-delete-current-issue-from-inside-comment-walks-up () + "Delete run from inside a comment subtree walks up and deletes the enclosing issue." + (test-pearl--in-org + "*** TODO ENG-1 Doomed\n:PROPERTIES:\n:LINEAR-ID: a\n:LINEAR-IDENTIFIER: ENG-1\n:END:\nbody\n**** Comments\n***** Someone — ts\n:PROPERTIES:\n:LINEAR-COMMENT-ID: c1\n:END:\ncommentbody\n" + (let ((deleted nil)) + (cl-letf (((symbol-function 'yes-or-no-p) (lambda (&rest _) t)) + ((symbol-function 'pearl--delete-issue-async) + (lambda (id cb) (setq deleted id) (funcall cb '(:success t))))) + (re-search-forward "commentbody") ; point inside the comment subtree + (pearl-delete-current-issue) + (should (equal "a" deleted)) ; climbed to the enclosing issue + (goto-char (point-min)) + (should-not (re-search-forward "Doomed" nil t)))))) + (ert-deftest test-pearl-delete-current-issue-failure-keeps-subtree () "A confirmed delete that fails on the remote leaves the subtree and its sibling intact." (test-pearl--in-org |