diff options
| author | Craig Jennings <c@cjennings.net> | 2026-07-11 02:13:15 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-07-11 02:13:15 -0500 |
| commit | cfbabf1da65c5224a4e3c7302c71baa98935d0e4 (patch) | |
| tree | b84a7484279dbffc27f396a18da3dd474538c702 /.ai/workflows | |
| parent | 06ca6c7c0a825fa9fed66cf17f94be8c0ed4d3da (diff) | |
| download | rulesets-cfbabf1da65c5224a4e3c7302c71baa98935d0e4.tar.gz rulesets-cfbabf1da65c5224a4e3c7302c71baa98935d0e4.zip | |
fix(task-review): accept org-native LAST_REVIEWED stamps, warn on bad ones
task-review-staleness.sh expected a bare 2026-07-09 and treated an org inactive timestamp ([2026-07-09 Thu], the form matching the CREATED:/CLOSED: cookies in the same drawer) as unparseable. The count branch folded that into the stale count, so a freshly-reviewed task reported as never-reviewed, and a full review pass never dropped the startup nudge. Both the bare and bracketed forms now normalize to the ISO date. A value that is neither warns loudly to stderr (file:line:value) and stays out of the count, since a data error shouldn't hide as "never reviewed." task-review.org documents the accepted format.
Tested red/green: 5 new bats cases (bracketed fresh and stale, list-mode sort by real date, malformed warns and is excluded). Full suite 273 ok.
Diffstat (limited to '.ai/workflows')
| -rw-r--r-- | .ai/workflows/task-review.org | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.ai/workflows/task-review.org b/.ai/workflows/task-review.org index 4a09545..7ea2e8e 100644 --- a/.ai/workflows/task-review.org +++ b/.ai/workflows/task-review.org @@ -92,7 +92,7 @@ Set =:LAST_REVIEWED:= to today's date (from above) in the task's =:PROPERTIES:= Body... #+end_example -The exact date string matters: =task-review-staleness.sh= and the wrap-up health check both parse =:LAST_REVIEWED: YYYY-MM-DD=. +Format: =:LAST_REVIEWED:= takes a bare ISO date (=2026-05-20=) or an org-native inactive timestamp (=[2026-05-20 Tue]=, matching the =CREATED:=/=CLOSED:= cookies beside it); =task-review-staleness.sh= and the wrap-up health check normalize both to the date. A value that is neither is a data error — the staleness script warns loudly to stderr (naming the file, line, and value) and leaves the task out of the stale count rather than silently reporting a freshly-reviewed task as never-reviewed. Stamp a clean date and the warning never fires. *** Killing a task |