diff options
| author | Craig Jennings <c@cjennings.net> | 2026-06-02 13:50:39 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-06-02 13:50:39 -0500 |
| commit | 9bc7e6730f5ca27bdff30089a34bca1e224da9e4 (patch) | |
| tree | e901786ef3f911f86c40ead0a4f53d7e55e81522 | |
| parent | 066faed99b2aaa221e18f3138b7ebd76a733c62c (diff) | |
| download | rulesets-9bc7e6730f5ca27bdff30089a34bca1e224da9e4.tar.gz rulesets-9bc7e6730f5ca27bdff30089a34bca1e224da9e4.zip | |
docs(review-code): require plain-text terminal output in Phase 5
The skill's chat echo (report, criterion table, verdict, draft summaries) was rendering bold and backtick spans as reverse video, which is hard to read in the terminal. Phase 5 now requires plain text for everything echoed to chat, while the artifact posted to GitHub keeps normal markdown. It's the same constraint as interaction.md's no-reverse-video rule, repeated at the print step where the violation actually happens.
| -rw-r--r-- | review-code/SKILL.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/review-code/SKILL.md b/review-code/SKILL.md index 78c5486..cec6b54 100644 --- a/review-code/SKILL.md +++ b/review-code/SKILL.md @@ -200,6 +200,8 @@ Remaining issues get tagged: ## Phase 5 — Output +**Terminal display — plain text only.** Everything this skill echoes to Craig in the chat terminal — the structured report, the per-criterion table, the verdict, and any draft summary or inline awaiting approval — must be rendered as plain text. No bold (`**`), no backtick code spans, no markdown tables, no headings-as-markup. They render as reverse video in his terminal and are hard to read. Write `file.py:42` as bare text, identifiers and `test:`-style prefixes unquoted, the criterion audit as a plain dashed list rather than a table, severity tiers as plain labels. This applies only to the terminal echo. The review actually posted to GitHub (the `gh api` body and inline blocks) keeps normal markdown — GitHub renders it correctly, so draft the posted artifact in markdown and strip the markup only when mirroring it into the chat. (Same rule as `interaction.md`'s no-reverse-video constraint; repeated here because the violation happens at exactly this print step.) + Before printing any approve/request-changes summary for posting, run the praise/correction gate (see Posted Summary Voice, and `/voice` personal #40): scan the summary and cut every clause that describes or justifies a good change — keep praise plus verdict only. Then confirm each finding and change-request states its why, gently and briefly. This is a mechanical pass, not a judgment call. ```markdown |