diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-22 15:17:11 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-22 15:17:11 -0500 |
| commit | efcc8e5ffdd09f538fd2d83824f4c632264ad96c (patch) | |
| tree | 01f3d856ccee3b719270abd0967f6c0b1cebc639 | |
| parent | b025f31c10eaa11860e9735dcff603d545cf83e6 (diff) | |
| download | rulesets-efcc8e5ffdd09f538fd2d83824f4c632264ad96c.tar.gz rulesets-efcc8e5ffdd09f538fd2d83824f4c632264ad96c.zip | |
chore(todo): close hooks README audit item
| -rw-r--r-- | todo.org | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -827,7 +827,7 @@ Each item below is a one-line summary of a sub-TODO further down. Tick the box w - [X] [#B] =elisp-testing.md=: batch-mode + native-comp caveats **** Hooks -- [ ] [#A] =hooks/README.md=: include =destructive-bash-confirm.py= in install/settings snippets +- [X] [#A] =hooks/README.md=: include =destructive-bash-confirm.py= in install/settings snippets - [ ] [#A] =hooks/git-commit-confirm.py= + =gh-pr-create-confirm.py=: inspect message/body files referenced by =-F= / =--body-file= - [ ] [#B] =hooks/destructive-bash-confirm.py=: shell-aware command parsing (not regex) @@ -1054,11 +1054,9 @@ Rephrased the "prefer Write over repeated Edits" bullet around intent: land nont Added three sections: Batch-Mode Reproducibility (=emacs --batch= as source of truth, no interactive-session state, no blocking prompts, deterministic), Isolating Emacs State (temp =user-emacs-directory=, explicit load-path, declared deps only, with an unwind-protect sandbox example), and Byte-Compile/Native-Comp Warnings (=byte-compile-error-on-warn=, native-comp gated on =native-comp-available-p= and kept opt-in/version-aware). -*** TODO [#A] =hooks/README.md=: include =destructive-bash-confirm.py= in install/settings snippets +*** 2026-05-22 Fri @ 15:16:22 -0500 Synced hooks/README install snippets with the destructive hook (opt-in) -The table documents the destructive-command hook, but the manual install and -settings JSON snippets only include the commit and PR hooks. Add the destructive -hook to both snippets so documented installation matches the listed hooks. +Brought the README's manual-install and settings-JSON snippets in line with the canonical =hooks/settings-snippet.json= (which already wires all three) and the Makefile's opt-in design: added the destructive-bash-confirm.py symlink as an opt-in step, added its settings entry, and reworded the note to say all three are no-op-safe but the destructive gate is opt-in (=make install-hooks= excludes it by default — link manually before relying on the snippet entry). *** TODO [#A] =hooks/git-commit-confirm.py= and =hooks/gh-pr-create-confirm.py=: inspect message/body files |