diff options
| author | Craig Jennings <c@cjennings.net> | 2026-04-24 19:02:22 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-04-24 19:02:22 -0500 |
| commit | f173e5c3218262c8c803e797b712cdf25f9dc33c (patch) | |
| tree | cb336ef3d1ddc48cef11d4ee6def773deac322b4 | |
| parent | 1ad76e94b55462f4463a07b4fe44df7d3b89ca07 (diff) | |
| download | rulesets-f173e5c3218262c8c803e797b712cdf25f9dc33c.tar.gz rulesets-f173e5c3218262c8c803e797b712cdf25f9dc33c.zip | |
docs(commits): require explicit reviewer requests on PR creation
Adds step 7 to the Review-and-Publish PR-description flow: pass
--reviewer at create time or use gh pr edit --add-reviewer right
after. Notes that CODEOWNERS auto-suggestions aren't requests, that
picking reviewers should follow the team's per-repo convention, and
that follow-up PRs benefit from tagging the parent PR's author.
Renumbers the Linear-comment and Dev-Review status steps accordingly.
| -rw-r--r-- | claude-rules/commits.md | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 882c948..615ea32 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -136,12 +136,21 @@ enough to skip review" exemption on top of it. 5. Stop and tell the user the draft is open for review. Wait for explicit approval. 6. After approval, split the file on the first blank line and pass the title and body to `gh pr create --title "..." --body "$(tail -n +3 <file>)"` (or - a heredoc) so formatting is preserved. -7. After `gh pr create` returns a URL, post a comment on the linked Linear + a heredoc) so formatting is preserved. Add `--reviewer <user[,user...]>` + in the same call when you already know who should review. +7. Request reviewers on the new PR if you didn't pass `--reviewer` at create + time. Use `gh pr edit <N> --add-reviewer <user>`. If the repo has a + `CODEOWNERS` file, GitHub auto-suggests based on touched paths; still + issue the explicit request so the reviewer gets notified. Pick reviewers + per the team's convention for the area touched (often documented in the + per-repo `CLAUDE.md`). For follow-up PRs, consider tagging the parent + PR's author if their context would help. PRs without a human reviewer + request stall — "checks passed" is not a substitute for review. +8. After `gh pr create` returns a URL, post a comment on the linked Linear ticket with the PR URL (use the Linear MCP `save_comment` tool, or open the ticket manually if MCP is unavailable). This closes the ticket→PR direction of the cross-link. -8. Move the Linear ticket to the "Dev Review" status (use `save_issue` with +9. Move the Linear ticket to the "Dev Review" status (use `save_issue` with the Dev Review state ID, or the Linear UI). The ticket should not remain "In Progress" once a PR is open against it. |