diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-13 05:15:55 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-13 05:15:55 -0500 |
| commit | f24f0d873e79b0ea9904822c9ff46eb9d63a5ba7 (patch) | |
| tree | e934916e6995e2468e3be6b895ded819d0470ebe | |
| parent | b77a18d08a5c82415668ca30a77677a533d67298 (diff) | |
| download | rulesets-f24f0d873e79b0ea9904822c9ff46eb9d63a5ba7.tar.gz rulesets-f24f0d873e79b0ea9904822c9ff46eb9d63a5ba7.zip | |
fix(commits): correct PR-review notification channel ID
Step 8 of the publish flow referenced C0AM2MWHCJU as the channel for the Slack PR-author ping. That ID is actually a 3-person mpdm (Craig/Vrezh/Kostya), not the intended 4-person PR-review group. Corrected to C0B1B0NH2N5 (Craig/Eric/Vrezh/Kostya) and added a clarifying note that the 3-person mpdm is not an "#ai" channel despite older references calling it that.
| -rw-r--r-- | claude-rules/commits.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 754c53f..6c1d275 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -383,7 +383,7 @@ Pick the shape first. Most reviews are Shape 1. 7. Verify the review landed. `gh api repos/<owner>/<repo>/pulls/<N>/reviews --hostname ...` returns the latest review with bundled inlines. Confirm `state` matches the verdict and the inline count matches what was posted. -8. **Notify the PR author on Slack** (`APPROVE` or `REQUEST_CHANGES` verdicts only). After the review posts, send a one-line Slack message to channel `C0AM2MWHCJU` via the `slack-deepsat` MCP. No `/voice personal` pass — the message is short and templated. Two cases: +8. **Notify the PR author on Slack** (`APPROVE` or `REQUEST_CHANGES` verdicts only). After the review posts, send a one-line Slack message to the PR-review group DM `C0B1B0NH2N5` (the mpdm with Craig, Eric, Vrezh, Kostya — *not* `C0AM2MWHCJU`, which is a separate 3-person Craig/Vrezh/Kostya mpdm and is *not* an "#ai" channel despite older notes calling it that) via the `slack-deepsat` MCP. No `/voice personal` pass — the message is short and templated. Two cases: - Approved: `<@author-slack-id> Approved PR #N.\n<pr-url>` - Changes requested: `<@author-slack-id> Changes Requested PR #N\n<pr-url>` Replace `#N` with the PR number and `<pr-url>` with the GHE URL of the PR. Always lead with an `<@author-slack-id>` mention so the engineer who owns the merge decision gets pinged — the message is useless without it. Resolve the Slack user ID via the slack-deepsat `users_search` tool using the PR author's name or email. The URL goes on its own line, immediately after the message. If the MCP doesn't have a post-message tool registered (for example, in a project where the Slack MCP is read-only), surface that to the user and skip the post — don't fall back to a different channel or asking the user to paste it. |