diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-18 01:28:47 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-18 01:28:47 -0500 |
| commit | 986bb4c368b1072a4671aecb16fa05b74ecac893 (patch) | |
| tree | f9139073bc7624bd491965a5745b03b46e94acc7 /claude-rules | |
| parent | 470085f4220afabb3b487f9342ed6bc35f5feca0 (diff) | |
| download | rulesets-986bb4c368b1072a4671aecb16fa05b74ecac893.tar.gz rulesets-986bb4c368b1072a4671aecb16fa05b74ecac893.zip | |
docs(commits): check disk before declaring /review-code unavailable
Step 1 told the agent to run /review-code but didn't say what to do when the skill exists on disk yet isn't in the session's available-skills list. The list covers plugin-installed skills only. User commands under ~/.claude/commands/ are routable as slash-commands but don't appear in it, so the agent could declare /review-code unavailable and fall through to the trivial-one-liner exception in Step 2.
The new Discovery check tells the agent to verify both ~/.claude/commands/review-code.md and ./.claude/commands/review-code.md on disk before declaring the skill unavailable, and surface the mismatch rather than auto-skipping.
Also drops three absorbed or stale inbox files: the skill-discovery handoff (signal absorbed by this edit), the missing-inbox-dir handoff (already resolved by 470085f), and a stale date-coverage scan output (deferred until the task-review habit lands).
Diffstat (limited to 'claude-rules')
| -rw-r--r-- | claude-rules/commits.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 9e1a8e0..41d17e7 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -272,6 +272,8 @@ Run the `review-code` skill against the change: - Before a PR: `/review-code` (branch diff against `main` merge-base) - Before commenting on someone else's PR: `/review-code <PR#>` +**Discovery check.** If `/review-code` doesn't appear in the session's available-skills list, check `~/.claude/commands/review-code.md` and `./.claude/commands/review-code.md` on disk before declaring it unavailable. The available-skills enumeration covers plugin-installed skills but can miss user commands under `~/.claude/commands/`, which are still routable as slash-commands. If either file exists, surface the discrepancy to the user before falling through to the trivial-one-liner exception in Step 2 — don't auto-skip. + Surface **all** findings to the user: Critical, Important, and Minor. **Default block:** any Critical or Important finding stops the flow. Fix the |