diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-22 15:48:48 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-22 15:48:48 -0500 |
| commit | 8c291b81cd7fb10479a55fb47e9a9cebcfc1b9b8 (patch) | |
| tree | 9f4d2fc7d3dff7f5404576759fee9d4a44f74b73 /scripts/tests | |
| parent | e6f8db82fb3e97ebf11866de2166ff4505871c21 (diff) | |
| download | rulesets-8c291b81cd7fb10479a55fb47e9a9cebcfc1b9b8.tar.gz rulesets-8c291b81cd7fb10479a55fb47e9a9cebcfc1b9b8.zip | |
refactor(skills): locator-first playwright guidance, drop emoji markers
Two cleanups to the playwright skills, landed together since they overlap the same files.
The skills taught networkidle as the readiness check and leaned on raw page.click/fill/waitForSelector. Playwright discourages networkidle for readiness, so the guidance in both SKILL.md files now waits for a visible app landmark via a web assertion or locator, the login and form examples use getByLabel/getByRole plus expect, the API reference leads with that pattern, and lib/helpers.js defaults waitForPageReady to load (preferring a caller-supplied landmark) and races the success indicator in authenticate instead of waiting on networkidle.
The second cleanup strips emoji console markers across run.js, helpers.js, both SKILL.md files, and the py examples, replacing each with a plain ASCII tag like [ok], [error], or [scan]. node --check and py_compile pass, and an emoji grep comes back clean.
Diffstat (limited to 'scripts/tests')
0 files changed, 0 insertions, 0 deletions
