fix(test): stop rename-ai-artifact.bats flaking on git auto-maintenance

The two "refuses when..." tests failed intermittently under full-suite load, always in teardown with "rm: cannot remove .git: Directory not empty." A git command in the setup or body armed background auto-maintenance (git runs maintenance run --auto after a commit), which wrote into .git after the test body and raced teardown's rm -rf. Disabling gc.auto and maintenance.auto in the throwaway repo, before any git command can arm them, removes the background writer. Diagnose-not-mask: kill the writer rather than retry the rm. Verified with 30 repeated file runs plus two full-suite runs, all green.

1 files changed, 11 insertions, 1 deletions

diff --git a/scripts/tests/rename-ai-artifact.bats b/scripts/tests/rename-ai-artifact.bats
index f00c92f..ea7f36e 100644
--- a/scripts/tests/rename-ai-artifact.bats
+++ b/scripts/tests/rename-ai-artifact.bats
@@ -27,7 +27,17 @@ setup() {
     printf 'Old session mentioning foo and foo.org — this is history.\n' > "$base/sessions/2026-01-01-old.org"
   done
   printf 'See foo.org and foo-helper.py. Also foobar.org stays.\n' > "$REPO/notes.org"
-  ( cd "$REPO" && git init -q && git add -A && git -c user.email=t@t -c user.name=t commit -qm init )
+  # Disable background auto-maintenance/gc before any git command can arm it:
+  # otherwise a post-commit `git maintenance run --auto` writes into .git after
+  # the test body and races teardown's `rm -rf`, which then fails intermittently
+  # with ".git: Directory not empty". Diagnose-not-mask: kill the writer, don't
+  # retry the rm.
+  ( cd "$REPO" \
+      && git init -q \
+      && git config gc.auto 0 \
+      && git config maintenance.auto false \
+      && git add -A \
+      && git -c user.email=t@t -c user.name=t commit -qm init )
 }
 
 teardown() {