diff options
| -rw-r--r-- | todo.org | 36 |
1 files changed, 12 insertions, 24 deletions
@@ -775,10 +775,10 @@ Each item below is a one-line summary of a sub-TODO further down. Tick the box w - [X] [#B] =review-code=: relax three-strengths rule for tiny/failing diffs **** PR / review responses -- [ ] [#A] =respond-to-review=: remove review-process language from commit messages -- [ ] [#B] =respond-to-review=: use unresolved threads + resolution state -- [ ] [#B] =respond-to-cj-comments=: drop personal absolute paths from public-writing -- [ ] [#B] =respond-to-cj-comments=: fallback when =humanizer= or =emacsclient= unavailable +- [X] [#A] =respond-to-review=: remove review-process language from commit messages +- [X] [#B] =respond-to-review=: use unresolved threads + resolution state +- [X] [#B] =respond-to-cj-comments=: drop personal absolute paths from public-writing (moot — already clean) +- [X] [#B] =respond-to-cj-comments=: fallback when =humanizer= or =emacsclient= unavailable (moot — superseded by /voice + VERIFY pattern) **** Branch workflow - [ ] [#A] =finish-branch=: fix base-branch detection @@ -957,33 +957,21 @@ Expanded the Content scope section in =review-code/SKILL.md= with two modes: a p Changed all three "three minimum" spots in =review-code/SKILL.md= (Strengths section, Critical Rules DO list, Anti-Patterns) to "up to three specific; say none found on a tiny or weak diff." Reframed the old "No Strengths section" anti-pattern as "Skipping strengths out of laziness" so a substantive diff still demands them while a weak one can honestly report nothing notable. Landed alongside Craig's adjacent edit telling reviewers not to explain why a strength is good (sycophantic padding). -*** TODO [#A] =respond-to-review=: remove review-process language from commit messages +*** 2026-05-22 Fri @ 14:12:24 -0500 Removed review-process language from respond-to-review commit guidance -The skill suggests commits like =fix: Address review — [description]=, which -conflicts with =commits.md='s "what changed and why, not the process" rule and -also uses a non-ASCII dash. Replace with conventional subjects that name the -actual fix, e.g. =fix: validate export filename=. +Replaced the =fix: Address review — [description]= example (and the matching description-line phrasing) in =.claude/commands/respond-to-review.md= with "name the actual fix (=fix: validate export filename=), not the review that prompted it." Killed the non-ASCII dash and the process-in-commit pattern that conflicted with =commits.md=. -*** TODO [#A] =respond-to-review=: use unresolved review threads and resolution state, not only flat comments +*** 2026-05-22 Fri @ 14:12:24 -0500 Made respond-to-review fetch unresolved threads + resolve after verification -Fetching inline and top-level comments via REST misses thread resolution and -can re-process already-resolved feedback. Add the same thread-level workflow as -the GitHub comment-addressing skill: gather unresolved threads, group by -requested change, implement, reply, and resolve only after verification. +Rewrote section 1 (Gather) in =.claude/commands/respond-to-review.md= to pull =reviewThreads= via =gh api graphql= with =isResolved=, skipping already-resolved threads so settled feedback isn't re-processed; top-level conversation comments still come from REST. Added a section-4 step: reply and resolve a thread only after the fix is verified, never before. -*** TODO [#A] =respond-to-cj-comments=: remove personal absolute path references from public-writing instructions +*** 2026-05-22 Fri @ 14:12:24 -0500 Verified respond-to-cj-comments no longer embeds an absolute path (moot) -The skill embeds =/home/cjennings/code/rulesets/claude-rules/commits.md= in -the public-writing section. That contradicts the public-artifact scope rule. -Refer to "the commit/public-writing rules" internally, and ensure any emitted -public text never cites the local path. +Already resolved by a prior migration: =grep= for =/home/= and =/Users/= in =.claude/commands/respond-to-cj-comments.md= returns nothing. The public-writing section refers to the rules by name, not by local path. No edit needed. -*** TODO [#A] =respond-to-cj-comments=: add fallback when =humanizer= or =emacsclient= is unavailable +*** 2026-05-22 Fri @ 14:12:24 -0500 Closed respond-to-cj-comments humanizer/emacsclient fallback (largely moot) -The workflow requires =/humanizer= and opens long summaries in =emacsclient=. -Neither is guaranteed in a fresh environment. Add tool-availability checks and -fallbacks: apply the style passes inline if =humanizer= is absent, and write the -summary file path without opening an editor if =emacsclient= fails. +Overtaken by two later changes: =/humanizer= was replaced by =/voice personal= (no =/humanizer= invocation remains), and the mandatory =emacsclient= summary-open was replaced by the in-place VERIFY-task pattern (workflow line ~262, Craig's 2026-05-12 standing instruction). Only a stale descriptive phrase remained — tidied "humanizer's signs of AI writing" to "the signs of AI writing." The original fresh-environment-fallback concern no longer applies as written. *** TODO [#A] =finish-branch=: fix base-branch detection |