diff options
| -rw-r--r-- | claude-rules/commits.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 72b1859..9aedd4a 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -141,6 +141,8 @@ Applies to commit bodies, PR descriptions, and PR comments (review replies, foll **Brief. Terse is preferred.** A one-sentence body beats a paragraph saying the same thing. If the subject line covers it, skip the body entirely. Cut every clause that restates what the diff or the PR card already shows. Length is not a proxy for care. Rhetorical padding ("worth noting", "it's important to understand") always comes out; keep what a reader will actually use. +**Follow-up approvals stay terse.** A re-review that just confirms prior CHANGES_REQUESTED feedback got addressed should be `Approved.` and nothing more. The fixes are visible in the diff and in the prior review thread, so restating them adds noise. The first round of substantive review gets a real comment. Subsequent sign-offs after fixes do not. Counts as a trivial one-liner under the Step 2 exception, so the draft-file flow can be skipped. + **Kind.** PR comments and review replies are directed at a specific person. Acknowledge them when it fits ("thanks for the review") without pouring it on. When you disagree or push back, frame it as your read rather than a correction ("I think...", "my read was...", "did you mean X?"). Leave room for the other person to have seen something you didn't. A polite question beats a defensive explanation. Kindness is free and makes the next review cheaper. Focus on what was wrong and what was corrected. Not the mechanics. |