summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--todo.org106
1 files changed, 71 insertions, 35 deletions
diff --git a/todo.org b/todo.org
index c4f1afa..76f4e75 100644
--- a/todo.org
+++ b/todo.org
@@ -1,40 +1,5 @@
ST Patches
* ST Patches Open Work
-** TODO [#B] externalpipe
-*** Verification Steps
-- cat externalpipe_test.html
-- run linkgrabber.sh from the examples section
->>>> links should appear in dmenu for the links in the screen
-
-after applying the externalpipe-eternal patch, do it again, but this time check that you have the whole file
-*** Description and URLs
-Reading and writing st's screen through a pipe.
-Example
-
-config.h example, binding TERMMOD + U to extract all visible URLs and present dmenu to select and open one:
-
-static char *openurlcmd[] = { "/bin/sh", "-c",
- "xurls | dmenu -l 10 -w $WINDOWID | xargs -r open",
- "externalpipe", NULL };
-Shortcut shortcuts[] = {
- ...
- { TERMMOD, XK_U, externalpipe, { .v = openurlcmd } },
-};
-
-(xurls and open are external scripts)
-xurls: https://raw.github.com/bobrippling/perlbin/master/xurls
-open: https://github.com/bobrippling/open
-Example Shell Scripts
-
- link grabber - similar to the function above, but without xurls dependency
- https://st.suckless.org/patches/externalpipe/linkgrabber.sh
- edit screen - open screen in $EDITOR for copying text
- https://st.suckless.org/patches/externalpipe/editscreen.sh
-
-https://st.suckless.org/patches/externalpipe/
-https://st.suckless.org/patches/externalpipe/st-externalpipe-0.8.4.diff
-When using the scrollback patch, you can apply this patch ontop in order to use externalpipe onto the entire terminal history:
-https://st.suckless.org/patches/externalpipe/st-externalpipe-eternal-0.8.3.diff
** TODO [#A] font2 (fallback font for glyphs + emojis)
st-font2-0.8.5.diff
** TODO [#A] right-click sends paste
@@ -77,6 +42,77 @@ Key bindings
https://st.suckless.org/patches/colorschemes/
https://st.suckless.org/patches/colorschemes/st-colorschemes-0.8.5.diff
+* ST Patches Cancelled
+** CANCELLED [#B] externalpipe
+*** 2023-07-23 @ 16:32:10 -0500 skipping this patch.
+*** 2023-07-23 @ 16:32:06 -0500 failed verification using the example in description
+
+zsh: segmentation fault (core dumped) ./st
+X Error of failed request: BadWindow (invalid Window parameter)
+ Major opcode of failed request: 3 (X_GetWindowAttributes)
+ Resource id in failed request: 0x2200006
+ Serial number of failed request: 24
+ Current serial number in output stream: 25
+*** 2023-07-23 @ 15:56:30 -0500 Patch applied w/ intervention, but make produces warnings.
+Couldn't find proper match in st.h, but was about 4 lines off. The lines below the insert changed from another patch.
+However, make is producing warnings.
+
+In file included from st.c:20:
+st.c: In function ‘externalpipe’:
+st.c:2271:40: warning: passing argument 1 of ‘tlinelen’ makes pointer from integer without a cast [-Wint-conversion]
+ 2271 | lastpos = MIN(tlinelen(n) + 1, term.col) - 1;
+ | ^
+ | |
+ | int
+st.h:7:35: note: in definition of macro ‘MIN’
+ 7 | #define MIN(a, b) ((a) < (b) ? (a) : (b))
+ | ^
+st.c:450:15: note: expected ‘Line’ {aka ‘Glyph_ *’} but argument is of type ‘int’
+ 450 | tlinelen(Line line)
+ | ~~~~~^~~~
+st.c:2271:40: warning: passing argument 1 of ‘tlinelen’ makes pointer from integer without a cast [-Wint-conversion]
+ 2271 | lastpos = MIN(tlinelen(n) + 1, term.col) - 1;
+ | ^
+ | |
+ | int
+st.h:7:47: note: in definition of macro ‘MIN’
+ 7 | #define MIN(a, b) ((a) < (b) ? (a) : (b))
+ | ^
+st.c:450:15: note: expected ‘Line’ {aka ‘Glyph_ *’} but argument is of type ‘int’
+ 450 | tlinelen(Line line)
+ | ~~~~~^~~~
+
+*** Description and URLs
+Reading and writing st's screen through a pipe.
+Example
+
+config.h example, binding TERMMOD + U to extract all visible URLs and present dmenu to select and open one:
+
+static char *openurlcmd[] = { "/bin/sh", "-c",
+ "xurls | dmenu -l 10 -w $WINDOWID | xargs -r open",
+ "externalpipe", NULL };
+Shortcut shortcuts[] = {
+ ...
+ { TERMMOD, XK_U, externalpipe, { .v = openurlcmd } },
+};
+
+(xurls and open are external scripts)
+xurls: https://raw.github.com/bobrippling/perlbin/master/xurls
+open: https://github.com/bobrippling/open which leads here:
+ https://raw.githubusercontent.com/bobrippling/open/master/open
+
+
+Example Shell Scripts
+
+ link grabber - similar to the function above, but without xurls dependency
+ https://st.suckless.org/patches/externalpipe/linkgrabber.sh
+ edit screen - open screen in $EDITOR for copying text
+ https://st.suckless.org/patches/externalpipe/editscreen.sh
+
+https://st.suckless.org/patches/externalpipe/
+https://st.suckless.org/patches/externalpipe/st-externalpipe-0.8.4.diff
+When using the scrollback patch, you can apply this patch ontop in order to use externalpipe onto the entire terminal history:
+https://st.suckless.org/patches/externalpipe/st-externalpipe-eternal-0.8.3.diff
* ST Patches Completed
** DONE [#A] ligatures (apply after alpha and scrollback)
*** 2023-07-23 @ 15:31:37 -0500 Tested and working fine