diff options
| author | Craig Jennings <c@cjennings.net> | 2026-05-02 11:08:52 -0500 |
|---|---|---|
| committer | Craig Jennings <c@cjennings.net> | 2026-05-02 11:08:52 -0500 |
| commit | 29f04ead4051b79206626b5eb3ad0ed91e7f1d42 (patch) | |
| tree | 21881356237649b8e7c989338fc615241b8d22ed | |
| parent | b530c78cbfd9a6d49ac0c531b2f222b9620cf8c0 (diff) | |
| download | rulesets-29f04ead4051b79206626b5eb3ad0ed91e7f1d42.tar.gz rulesets-29f04ead4051b79206626b5eb3ad0ed91e7f1d42.zip | |
docs(commits): drop "on" from Slack notify templates
| -rw-r--r-- | claude-rules/commits.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/claude-rules/commits.md b/claude-rules/commits.md index 64b0177..72b1859 100644 --- a/claude-rules/commits.md +++ b/claude-rules/commits.md @@ -286,8 +286,8 @@ enough to skip review" exemption on top of it. - Inline code comment pinned to a specific line/hunk: no direct `gh` flag — use `gh api /repos/<owner>/<repo>/pulls/<N>/comments -F body=@/tmp/pr-<N>-comment.md -F commit_id=... -F path=... -F line=...`. 7. Verify the comment landed. `gh api /repos/<owner>/<repo>/pulls/<N>/reviews` for review-shaped comments, `gh api /repos/<owner>/<repo>/issues/<N>/comments` for issue-thread comments. 8. **Notify the PR author on Slack** (review-shaped comments only — `--approve` or `--request-changes`). After the review posts, send a one-line Slack message to channel `C0AM2MWHCJU` via the `slack-deepsat` MCP. No humanizer or personal-style passes — the message is short and templated. Two cases: - - Approved: `Approved on PR #N.\n<pr-url>` - - Changes requested: `Changes Requested on PR #N\n<pr-url>` + - Approved: `Approved PR #N.\n<pr-url>` + - Changes requested: `Changes Requested PR #N\n<pr-url>` Replace `#N` with the PR number and `<pr-url>` with the GHE URL of the PR. The URL goes on its own line, immediately after the message. If the MCP doesn't have a post-message tool registered (for example, in a project where the Slack MCP is read-only), surface that to the user and skip the post — don't fall back to a different channel or asking the user to paste it. Skip this step for plain `--comment` reviews (informal feedback, not a verdict) and for issue-thread or inline code comments. Approve and request-changes are the only verdicts that warrant the notification. |